Evan/challenge submission flows#66
Open
evanzhong wants to merge 4 commits into
Open
Conversation
… that listens on lastUpdated field on individual user object
kristielim
reviewed
Jan 20, 2020
| let alternator = true; | ||
| console.log("\n\n\nEntered renderTodos") | ||
| // console.log(openedChallenges) | ||
| for (challenge of openedChallenges) { |
Owner
There was a problem hiding this comment.
Should be let challenge of openedChallenges
Collaborator
Author
There was a problem hiding this comment.
wait, is this why it wasn't saving...
| function renderSubmitted() { | ||
| let submitted = []; | ||
| let alternator = true; | ||
| for (challenge of challenges) { |
kristielim
requested changes
Jan 23, 2020
kristielim
left a comment
kristielim
left a comment
Owner
There was a problem hiding this comment.
Remove or comment log statements and use const/let in loops. Otherwise looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP:
props.navigation.getParamwhere it's not pulling the right challenge object. Probably an incorrect implementation of the navigation library. Currently getParam is run in the lifecycle hookcomponentDidMount())Currently done:
getAllAssignedChallenges()