Skip to content

improve: add clean coding standards copilot instructions#229

Open
juliusvonkohout wants to merge 3 commits intomainfrom
copilot-instructions
Open

improve: add clean coding standards copilot instructions#229
juliusvonkohout wants to merge 3 commits intomainfrom
copilot-instructions

Conversation

@juliusvonkohout
Copy link
Copy Markdown
Member

@juliusvonkohout juliusvonkohout commented Feb 27, 2026

To make sure that we get proper pull requests from GSOC students.

Added clean coding standards to guide code quality and readability.

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout juliusvonkohout changed the title Add clean coding standards documentation Add clean coding standards copilot instructions Feb 27, 2026
@juliusvonkohout juliusvonkohout changed the title Add clean coding standards copilot instructions improve: add clean coding standards copilot instructions Feb 27, 2026
@juliusvonkohout
Copy link
Copy Markdown
Member Author

/approve

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment thread .github/copilot-instructions.md Outdated
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 27, 2026 16:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new .github/copilot-instructions.md file to establish clean coding standards for GitHub Copilot-assisted development in the Kubeflow Dashboard repository. The guidelines emphasize scientific elegance, minimalism, and long expressive names over abbreviations, along with principles about testing, documentation, and development practices.

Changes:

  • Created .github/copilot-instructions.md with coding standards including naming conventions, testing requirements, and development workflow guidance

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@christian-heusel christian-heusel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make sure that we get proper pull requests

Also is this the approach that we should take in this case? I'd argue that if the things the .github/copilot-instructions.md currently tries to fix are the problems that we're facing then we shouldn't accept those contributions anyways 😅

Also I think in the last community meeting the idea came up to establish a Kubeflow wide policy for AI usage, potentially something similar to https://www.kubernetes.dev/docs/guide/pull-requests/#ai-guidance.

I think that this especially makes sense given that the project seems to have a shortage of reviewers/maintainers rather than contributors 🤔

@google-oss-prow google-oss-prow Bot added the lgtm label Feb 27, 2026
@thesuperzapper
Copy link
Copy Markdown
Member

I am more concerned about not having an AI policy for the repo in the first place.

Adding this file implies that we will accept AI generated PR's , which I think needs to be qualified by a policy around users not raising generated PRs they have not reviewed first, and setting the expectation that users must understand ALL changes they are proposing as if they had written them themselves.

I am also not sure there is much value from a code perspective in these instructions, any "rule" we have for AI is a rule for human contributors too, and some of the listed rules here are not rules we enforce on humans.

/hold

@kubeflow kubeflow deleted a comment from Copilot AI Feb 28, 2026
@kubeflow kubeflow deleted a comment from Copilot AI Feb 28, 2026
@kubeflow kubeflow deleted a comment from Copilot AI Feb 28, 2026
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@google-oss-prow
Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow Bot removed the lgtm label Feb 28, 2026
@juliusvonkohout
Copy link
Copy Markdown
Member Author

I am more concerned about not having an AI policy for the repo in the first place.

Adding this file implies that we will accept AI generated PR's , which I think needs to be qualified by a policy around users not raising generated PRs they have not reviewed first, and setting the expectation that users must understand ALL changes they are proposing as if they had written them themselves.

I am also not sure there is much value from a code perspective in these instructions, any "rule" we have for AI is a rule for human contributors too, and some of the listed rules here are not rules we enforce on humans.

/hold

So there is now some feedback on PRs from github copilot, to provide some base data of usefulness, even without the policy here.
Actually these rules seem quite useful too me to have some base standard for code quality and guide contibutors to commit readable and maintainable code.
I also added an AI policy as suggested above directly in the copilot instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants