fix: allow same ServicePort with different hosts in driverIngressOptions

[puwun]

Fixes #2662

Purpose of this PR

Users want to expose the same Spark driver port (e.g 4040 for Spark UI) through multiple ingresses with different hostnames. The current validation incorrectly rejects this configuration as "duplicate ServicePort".

Proposed changes:

• Modified validation to check (ServicePort, IngressURLFormat) pairs instead of just ServicePort, allowing same port with different hosts
• Updated service and ingress naming to include index for multiple entries with the same port to ensure unique resource names
• Added tests for the new behavior

Change Category

• Bugfix (non-breaking change which fixes an issue)

Checklist

• I have conducted a self-review of my own code.
• I have updated documentation accordingly.
• I have added tests that prove my changes are effective or that my feature works.
• Existing unit tests pass locally with my changes.

Additional Notes

With this fix, the following configuration is now valid:

driverIngressOptions:
  - servicePort: 4040
    ingressURLFormat: "private.domain.com"
  - servicePort: 4040
    ingressURLFormat: "public.domain.com"

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yuchaoran2011 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Pull request overview

This PR fixes an issue where users could not expose the same Spark driver port (e.g., 4040 for Spark UI) through multiple ingresses with different hostnames. The validation logic has been updated to allow this configuration, and naming has been adjusted to ensure unique resource names.

Changes:

• Modified validation to check for duplicate (ServicePort, IngressURLFormat) pairs instead of rejecting duplicate ServicePort values
• Updated service and ingress naming to include an index suffix when multiple entries share the same port
• Added validation tests for the new behavior

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
internal/webhook/sparkapplication_validator.go	Removed duplicate ServicePort check, added check for duplicate IngressURLFormat, and added redundant validation for (port, url) pairs
internal/webhook/sparkapplication_validator_test.go	Renamed test to reflect new behavior allowing same port with different hosts, added test for duplicate host validation
internal/controller/sparkapplication/controller.go	Added index parameter to driver ingress creation calls in the reconciliation loop
internal/controller/sparkapplication/driveringress.go	Added index parameter to naming functions and updated service/ingress name generation to include index suffix for non-zero indices
internal/controller/sparkapplication/driveringress_test.go	Updated test calls to include index parameter (0) for existing tests

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[nabuskey]

Why do you want to use index for ingress name uniqueness?