fix: requeue manual deployments when bakeStatus is Deploying#46
Merged
Conversation
When handleBakeTime transitions Deploying→InProgress, the refetched rollout may still show Deploying due to informer cache lag. The manual deployment monitor only checked for InProgress, so it logged "No requeue needed" and dropped the 10s requeue from handleBakeTime entirely. Accept both BakeStatusDeploying and BakeStatusInProgress in the monitor condition so bake is continuously polled (every 10s) from the moment of deployment until health checks clear and bake starts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleBakeTimetransitions a manual deployment fromDeploying→InProgress, the refetched rollout may still showDeployingdue to informer cache lag. The manual deployment monitor only checked== BakeStatusInProgress, so it logged "No requeue needed" and dropped the 10s requeue — causing a 60+ second gap before bake started.BakeStatusDeployingandBakeStatusInProgressin the condition atrollout_controller.go:319, so the controller continuously polls (every 10s) from deployment until health checks clear and bake starts."should requeue manual deployment when bake is still Deploying (health checks not healthy)"which failed before the fix and passes after.Test plan
make testpasses in rollout-controllerwantedVersionto trigger manual deploy, verify "Manual deployment bake active, requeuing to monitor" appears in logs withbakeStatus: "Deploying"andrequeueAfter: "10s"immediately after deployment🤖 Generated with Claude Code