Add test-e2e-kind target with hack script and artifact collection#270
Conversation
✅ Deploy Preview for node-readiness-controller ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
size/L
|
Id also consider this to be Reliability improvement on, so cc @vitorfloriano when you find time to get to this. |
vitorfloriano
left a comment
vitorfloriano
left a comment
There was a problem hiding this comment.
Overall, looks good! Just a few inquiries.
/lgtm
| KIND_CLUSTER="${KIND_CLUSTER:-nrr-test}" | ||
| USE_EXISTING_CLUSTER="${USE_EXISTING_CLUSTER:-false}" | ||
| ARTIFACTS="${ARTIFACTS:-.}" | ||
| E2E_KIND_VERSION="${E2E_KIND_VERSION:-v1.36}" |
There was a problem hiding this comment.
I'm wondering if there could be a way to not have v1.36 hardcoded here.
There was a problem hiding this comment.
this is a fall back value (to latest k8s version)
i think we can keep it as it is (unless you mean something else?)
There was a problem hiding this comment.
I mean, the latest version is always a moving target and having any value hardcoded in here is something more we need to remember to update when we change to the next version.
But since it's a fallback value, that's fine. We can try to automate the version bump later with the release automation, check every places where k8s version is hardcoded and update.
k8s-ci-robot
added
the
lgtm
Priyankasaggu11929
force-pushed
the
setup-kind-e2e-tests
branch
from
ded3b17 to
e82482a
Compare
k8s-ci-robot
removed
the
lgtm
|
Thanks for the review @vitorfloriano. Addressed all comments and left explanation for one. |
vitorfloriano
left a comment
vitorfloriano
left a comment
There was a problem hiding this comment.
Looks good! Thanks!
/lgtm
k8s-ci-robot
added
the
lgtm
|
@Priyankasaggu11929 Thanks! when you find time can you also get to our TEST/README files if they need an update for this? /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajaysundark, Priyankasaggu11929, vitorfloriano The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kept a TODO for myself. (will address it in july 1st week) |
4 participants
Following the k/jobset repo's pattern - https://github.com/kubernetes/test-infra/blob/98798bcae0a846ab0c1938f81044844a7df148f3/config/jobs/kubernetes-sigs/jobset/jobset-periodics-main.yaml
PR is adding a new
hack/e2e-test.shand atest-e2e-kindmakefile target, that handles Kind cluster creation, artifact collection, and log export in one place.This is prep work for the PR kubernetes/test-infra#37165, to give us periodic e2e test signals for NRC across all latest supported Kubernetes releases.
Note:
With this, the existing
test-e2etarget is redundant now, but it is still in use in the GH Action workflow (we can clean it up later once all our GH actions CI jobs are migrated to Prow)./assign @ajaysundark