fix: target metrics patches to metrics-service only#277
Open
vitorfloriano wants to merge 1 commit into
Open
Conversation
The patch was targetting 'Service', which was too broad and being mistakenly applied to all services, including the webhook service, leading to a misconfig.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vitorfloriano The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for node-readiness-controller ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
size/XS
AvineshTripathi
left a comment
AvineshTripathi
left a comment
Contributor
There was a problem hiding this comment.
thanks for looking into this @vitorfloriano!
| - path: metrics_service_tls_patch.yaml | ||
| target: | ||
| kind: Service | ||
| name: metrics-service |
Contributor
There was a problem hiding this comment.
probaby we should add namespace(system) too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Prometheus TLS patch was targetting 'Service', which was too broad and being mistakenly applied to all services, including the webhook-service, leading to a misconfig and causing errors when validating custom resources (see #276).
This PR targets the patch to the metrics-service only.
Fixes #276
/kind bug
Testing
This was manually tested by running
make build-manifests-temp ENABLE_METRICS=true ENABLE_TLS=true ENABLE_WEBHOOK=trueand then inspecting the generated manifest, which now features the correct config:bin/build/manifests.yaml:
Checklist
make testpassesmake lintpassesDoes this PR introduce a user-facing change?
Doc #278