contrib guide: Describe how to resolve merge conflicts#8951
Conversation
|
This is a good start, but I feel like a section called "Resolving Merge Conflicts" needs to provide some actual instructions on how to resolve them. Links to public git/github resources are fine, if they are good instructions. |
Link to GtiHub docs about merge conflicts
|
|
||
| The Kubernetes project maintains high development velocity, so it's likely other | ||
| PRs will merge which introduce merge conflicts while Feature-X is being | ||
| PRs will merge which introduce [merge conflicts] while Feature-X is being |
There was a problem hiding this comment.
This is a good start, but I feel like a section called "Resolving Merge Conflicts" needs to provide some actual instructions on how to resolve them. Links to public git/github resources are fine, if they are good instructions.
Added this link to GitHub's docs which provide a good entrypoint: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts
These are the most similar Git docs I could find about resolving conflicts, but it's a bit buried in a larger sequence of steps and not as applicable in this context: https://git-scm.com/book/en/v2/Git-Branching-Basic-Branching-and-Merging#_basic_merge_conflicts
|
/hold for squash |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kelleretoro, nojnhuh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This PR updates the contributor guide to describe why
git mergeis preferable togit rebasefor resolving merge conflicts while a PR is being reviewed.Which issue(s) this PR fixes:
Fixes #