fix(logwatchers/kmsg): don't close parser from Stop()#1260
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Apr 10, 2026
Merged
fix(logwatchers/kmsg): don't close parser from Stop()#1260k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
Closing the parser in Stop() triggers kmsgparser's read goroutine to close its output channel, which made watchLoop take the restart path (added in kubernetes#1192) during intentional shutdown. Leave parser cleanup to watchLoop's defer, which is the single owner of the parser lifecycle.
k8s-ci-robot
added
cncf-cla: yes
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the parser in Stop() triggers kmsgparser's read goroutine to close its output channel, which made watchLoop take the restart path (added in #1192) during intentional shutdown. Leave parser cleanup to watchLoop's defer, which is the single owner of the parser lifecycle.
/cc @ameukam @wangzhen127 @SergeyKanzhelev