Skip to content

fix: detect pod IP changes in isAppPodStatusChanged #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdryaan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: detect pod IP changes in isAppPodStatusChanged #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daa7f52
fix: return nil explicitly in SliceGateway NONET early-exit path
mdryaan May 12, 2026
b5f2c26
fix: detect pod IP changes in isAppPodStatusChanged
mdryaan May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/slice/app_pod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func isAppPodStatusChanged(current []kubeslicev1beta1.AppPod, old []kubeslicev1b
}

for _, cp := range current {
if _, ok := oldPodMap[cp.PodName]; !ok {
if oldPodMap[cp.PodName] != cp.PodIP {
return true
}
}
Expand Down
69 changes: 69 additions & 0 deletions controllers/slice/reconciler_unit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,3 +196,72 @@ func TestHandleDnsSvc(t *testing.T) {
})
}
}

func TestIsAppPodStatusChanged(t *testing.T) {
tests := []struct {
name string
current []kubeslicev1beta1.AppPod
old []kubeslicev1beta1.AppPod
want bool
}{
{
name: "same pods same IPs",
current: []kubeslicev1beta1.AppPod{
{PodName: "pod-a", PodIP: "10.0.0.1"},
{PodName: "pod-b", PodIP: "10.0.0.2"},
},
old: []kubeslicev1beta1.AppPod{
{PodName: "pod-a", PodIP: "10.0.0.1"},
{PodName: "pod-b", PodIP: "10.0.0.2"},
},
want: false,
},
{
name: "same pod name different IP",
current: []kubeslicev1beta1.AppPod{
{PodName: "pod-a", PodIP: "10.0.0.99"},
},
old: []kubeslicev1beta1.AppPod{
{PodName: "pod-a", PodIP: "10.0.0.1"},
},
want: true,
},
{
name: "pod added to current",
current: []kubeslicev1beta1.AppPod{
{PodName: "pod-a", PodIP: "10.0.0.1"},
{PodName: "pod-b", PodIP: "10.0.0.2"},
},
old: []kubeslicev1beta1.AppPod{
{PodName: "pod-a", PodIP: "10.0.0.1"},
},
want: true,
},
{
name: "pod removed from current",
current: []kubeslicev1beta1.AppPod{
{PodName: "pod-a", PodIP: "10.0.0.1"},
},
old: []kubeslicev1beta1.AppPod{
{PodName: "pod-a", PodIP: "10.0.0.1"},
{PodName: "pod-b", PodIP: "10.0.0.2"},
},
want: true,
},
{
name: "both empty",
current: []kubeslicev1beta1.AppPod{},
old: []kubeslicev1beta1.AppPod{},
want: false,
},
}

for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
got := isAppPodStatusChanged(test.current, test.old)
if got != test.want {
t.Errorf("isAppPodStatusChanged() = %v, want %v", got, test.want)
}
})
}
}
2 changes: 1 addition & 1 deletion controllers/slicegateway/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func (r *SliceGwReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
if slice.Status.SliceConfig != nil &&
slice.Status.SliceConfig.SliceOverlayNetworkDeploymentMode == v1alpha1.NONET {
log.Info("No communication slice. Skipping slicegw reconcilation")
return ctrl.Result{}, err
return ctrl.Result{}, nil
}

// Check if slice router network service endpoint (NSE) is present before spawning slice gateway pod.
Expand Down