fix: remove stdlib log import from slice reconciler SetupWithManager#481
Open
mdryaan wants to merge 1 commit into
Open
fix: remove stdlib log import from slice reconciler SetupWithManager#481mdryaan wants to merge 1 commit into
mdryaan wants to merge 1 commit into
Conversation
…anager Signed-off-by: mdryaan <alikhurshid842001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
controllers/slice/reconciler.gowas importing the stdlib"log"package for a singlelog.Fatalfcall insideSetupWithManager. This bypasses the structured logger used everywhere else in the project, writes to stderr in a different format, and callsos.Exit(1)without giving the controller-runtime manager a chance to run shutdown hooks.Every other reconciler in this codebase returns errors from
SetupWithManager—main.goalready handles them with the structured logger andos.Exit(1). This just makes the slice reconciler consistent with that pattern.Changed
log.Fatalf("Error creating label requirement: %v", err)toreturn fmt.Errorf("error creating label requirement: %w", err)and removed the"log"import.fmtwas already imported so no new dependency is added.Fixes #480
How Has This Been Tested?
make fmt— no formatting changesmake vet— no issuesmake build— builds cleanlyChecklist:
go fmtDoes this PR introduce a breaking change?