fix: return (nil, nil) from GetSlice on NotFound to restore graceful requeue#483
Open
mdryaan wants to merge 1 commit into
Open
fix: return (nil, nil) from GetSlice on NotFound to restore graceful requeue#483mdryaan wants to merge 1 commit into
mdryaan wants to merge 1 commit into
Conversation
…ng error Signed-off-by: mdryaan <alikhurshid842001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
controllers.GetSlicewas returning(nil, NotFoundError)when the Slice CR didn't exist.The SliceGateway reconciler has aslice == nilguard at line 127 that requeues after 10 seconds — but it was dead code.GetSlicenever returned(nil, nil), so a NotFound result always hit the error path and triggered exponential backoff on every gateway reconcile untilthe Slice appeared.
Added an
errors.IsNotFoundcheck inGetSliceso it returns(nil, nil)on NotFound. Real API errors (permissions, timeouts, network) still propagate as before. The graceful 10s requeue path in the SliceGateway reconciler is now actually reachable.Fixes #482
How Has This Been Tested?
make fmt— no formatting changesmake vet— no issuesmake build— builds cleanlyChecklist:
go fmtDoes this PR introduce a breaking change?