fix: replace shared retryAttempts global with per-Cluster annotation in deregistration handler#485
Open
mdryaan wants to merge 1 commit into
Open
Conversation
Signed-off-by: mdryaan <alikhurshid842001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
handleClusterDeletionwas using a package-levelvar retryAttempts = 0to cap deregistration retries atMAX_CLUSTER_DEREGISTRATION_ATTEMPTS = 3. This had two problems:Removed the package-level var and moved attempt tracking into the Cluster object itself using the annotation
kubeslice.io/deregistration-attempts. On each failedcreateDeregisterJobcall, the annotation is incremented and patched back viaclient.MergeFrom. Each Cluster CR now has its own independent counter that survives pod restarts and concurrent deletions of other clusters.Fixes #484
How Has This Been Tested?
make fmt— no formatting changesmake vet— no issuesmake build— builds cleanlyChecklist:
go fmtDoes this PR introduce a breaking change?