fix: hub SliceGw controller logs r.ClusterName instead of package-level clusterName#487
Open
mdryaan wants to merge 1 commit into
Conversation
…iceGw log Signed-off-by: Md Raiyan <alikhurshid842001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
pkg/hub/controllers/slicegateway_controller.go, the cluster ownership check correctly usesr.ClusterName(the value injected into the reconciler at startup):But the
log.Infoon the next line was usingclusterName— the package-level variable initialised fromos.Getenv("CLUSTER_NAME")at package load time. If the env var is empty or unset when the package initialises, the log prints an empty string while the comparison uses the correct injected value. The two variables can diverge, making the log line misleading during debugging.Fix: replace
clusterNamewithr.ClusterNamein thelog.Infocall so the logged valueis always the same authoritative value used for the ownership check.Fixes #13
How Has This Been Tested?
make fmt— no formatting changesmake vet— no issuesmake build— builds cleanlyChecklist:
go fmtDoes this PR introduce a breaking change?