fix: propagate reconcile ctx through NetpolReconciler instead of context.Background()#492
Open
mdryaan wants to merge 1 commit into
Open
Conversation
…ext.Background() Signed-off-by: Md Raiyan <alikhurshid842001@gmail.com>
Author
|
Hey @gourishkb @Rahul-D78, Could you please have a look at this PR whenever you have time? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NetpolReconcilerwas usingcontext.Background()in five places insideCompare, one place insidegetSliceNameFromNsOfNetPol, and one directr.Getcall inReconcile. The reconcile context carries the deadline, cancellation signal, and structured logger set up by controller-runtime — dropping it means API calls in this reconciler ignore timeouts,can't be cancelled, and lose log correlation with the reconcile run they belong to.
Fixed by threading the reconcile
ctxthroughCompare(added as a parameter) andgetSliceNameFromNsOfNetPol(added as a parameter), and replacing everycontext.Background()call withctx.Fixes #491
How Has This Been Tested?
make fmt— no formatting changesmake vet— no issuesmake build— builds cleanlymake test— all suites pass; pre-existing spoke timeout failures confirmed identical on masterChecklist:
go fmtDoes this PR introduce a breaking change?