Re-exec fm-brief.sh under bash 5+ when env resolves to macOS 3.2 - #1180
Closed
prandelicious wants to merge 3 commits into
Closed
Re-exec fm-brief.sh under bash 5+ when env resolves to macOS 3.2#1180prandelicious wants to merge 3 commits into
prandelicious wants to merge 3 commits into
Conversation
Move delivery-mode Definition-of-done text into helper functions so bash 3.2 no longer chokes on command-substitution heredocs before the outer brief heredoc, and assert /bin/bash -n in the regression test. Co-authored-by: Cursor <cursoragent@cursor.com>
macOS PATH often resolves env bash to /bin/bash 3.2, which cannot parse ship-mode DOD heredocs inside command substitution. Add an early prologue that re-execs via Homebrew or /usr/local bash before that syntax is read, with a loop guard and loud brew-install error when no modern bash exists. Restore the original inline heredocs and add regression tests for re-exec. Co-authored-by: Cursor <cursoragent@cursor.com>
…ash is already 5+
Owner
|
thanks for digging into this. i merged #1093, which fixes the same macOS bash 3.2 parse failure by making fm-brief.sh itself 3.2-safe, so stock macOS works again without requiring a homebrew bash. closing this one as superseded. appreciate the help here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/fm-brief.shso brief scaffolding works whenenv bashresolves to macOS/bin/bash3.2/opt/homebrew/bin/bashor/usr/local/bin/bash) before unparseable ship-mode DOD heredoc syntax is parsedTest plan
bin/fm-lint.shpassestests/fm-brief.test.shpasses/bin/bash3.2 via re-execMade with Cursor