chore: CI updates, unit tests, portable desktop build, unified Prettier#48
Open
victalejo wants to merge 1 commit into
Open
chore: CI updates, unit tests, portable desktop build, unified Prettier#48victalejo wants to merge 1 commit into
victalejo wants to merge 1 commit into
Conversation
…fied Prettier
- Bumped GitHub Actions to v4 and Node to 20; added yarn cache and
--frozen-lockfile. Test workflow now runs lint, unit and e2e as three
parallel jobs with concurrency cancellation; also triggers on push to
master. Fixed build.yml download-artifact name mismatch.
- Added Jest (jest-expo) in packages/008 with tests for Cdr and utils
helpers. Root yarn test wires through lerna run test --no-bail.
- Replaced the shell one-liner build-desktop with scripts/build-desktop.js
for portability (works on Windows) and proper error handling. Added a
local eslintrc so the script lints with modern ecmaVersion.
- Consolidated Prettier config into a single root .prettierrc.json and
.prettierignore; removed duplicated per-package copies.
- Fixed invalid lint-staged glob "**/*.{js}" -> "**/*.js".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Low-risk, isolated technical improvements — no product behavior changes.
--frozen-lockfile. Thetestworkflow now runslint,unit, ande2eas three parallel jobs with
concurrencycancellation and also triggers onpush to
master. Fixed a latent bug inbuild.ymlwheredownload-artifactreferenced a non-existent artifact name.jest-expopreset) inpackages/008withtests for
Cdr(X-Call-ID precedence, inbound/outbound mapping,ringing → answered/missed transitions, wait/duration/total math) and
utils(cleanPhoneNumber,genId,sleep). Rootyarn testwiresthrough
lerna run test --no-bail.rm -rf … && mv … && cp -R …one-liner withscripts/build-desktop.js,which validates
web-buildexists, usesfsprimitives, and works onWindows. Added
scripts/.eslintrc.jsonso the script lints with modernecmaVersion..prettierrc.json+.prettierignoreat the repo root; removed near-identical per-package copies in
packages/008andpackages/008desktop. Effective config unchanged.**/*.{js}→**/*.js(single-value brace expansion was triggering a warning on every commit).