fix(config): resolve make test errors and refactor commit regex logic#27
Merged
Conversation
- Fix f-string regex escaping bug in get_commit_subject_regex generator. - Update test_config.py expectation for subject_max_length to 85. - Refactor commit regex logic: replace 'message_regex' with dynamically generated 'subject_regex'. - Update schema and rules to support the new subject_regex approach. - Standardize orchestrator instructions and constraints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes persistent
make testfailures related to configuration validation and refactors the commit message regex logic to be more robust and dynamic.Key Changes
get_commit_subject_regexgenerator that was producing invalid regex quantifiers.tests/test_config.pyto align with the project's defaultsubject_max_lengthof 85 characters.message_regexinrules.yamlwith a dynamically generatedsubject_regex(viaget_commit_subject_regex) to ensure DRY compliance across all orchestrators.schema.jsonandrules.yamlto reflect the removal of the redundantmessage_regexfield.Test Plan
make testlocally and verified all 14 tests pass.