update website id#2184
Open
5byuri wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates DevGuard’s telemetry configuration (Umami website ID) and adjusts related version/disable-flag handling in the API entrypoint and telemetry package.
Changes:
- Update Umami
WebsiteIDused for startup telemetry events. - Change
DEVGUARD_TELEMETRY_DISABLEDparsing to usestrconv.ParseBool(and update tests accordingly). - Modify API version/Sentry release wiring (currently introduces a compile error in
apiVersion()).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
telemetry/telemetry.go |
Updates WebsiteID and changes env parsing for the telemetry disable flag. |
telemetry/telemetry_test.go |
Updates the set of values expected to disable telemetry. |
cmd/devguard/main.go |
Removes build-time release var usage and adjusts version/Sentry release handling (contains a syntax error as-is). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
196
to
198
| func apiVersion() string { | ||
| return telemetry.RuntimeVersion(config.Version, release) | ||
| return telemetry.RuntimeVersion(config.Version, ) | ||
| } |
Member
Author
|
fixing this |
Signed-off-by: Lars <lschwan43@gmail.com>
…ard into telemetry-data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.