labgrid-raw-interface: Add permissions#1808
Open
JoshuaWatt wants to merge 1 commit intolabgrid-project:masterfrom
Open
labgrid-raw-interface: Add permissions#1808JoshuaWatt wants to merge 1 commit intolabgrid-project:masterfrom
JoshuaWatt wants to merge 1 commit intolabgrid-project:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1808 +/- ##
========================================
- Coverage 46.7% 46.7% -0.1%
========================================
Files 179 179
Lines 14202 14204 +2
========================================
Hits 6645 6645
- Misses 7557 7559 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7 tasks
Adds support for the helper.yaml file to specify which subcommands users are allowed to execute using labgrid-raw-interface. Denied commands will fail with an error. The RawNetworkInterfaceDriver is updated to query if the `ip` command is allowed before attemping to bring the interface up and down on activate/deactivate. This prevents it from erroring out if this behavior is not allowed Signed-off-by: Joshua Watt <Joshua.Watt@garmin.com>
3b71b31 to
5316793
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the helper.yaml file to specify which subcommands users are allowed to execute using labgrid-raw-interface. Denied commands will fail with an error.
The RawNetworkInterfaceDriver is updated to query if the
ipcommand is allowed before attemping to bring the interface up and down on activate/deactivate. This prevents it from erroring out if this behavior is not allowedDescription
Checklist