client: make error a bit more helpful#1844
Closed
Rubusch wants to merge 1 commit intolabgrid-project:masterfrom
Closed
client: make error a bit more helpful#1844Rubusch wants to merge 1 commit intolabgrid-project:masterfrom
Rubusch wants to merge 1 commit intolabgrid-project:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1844 +/- ##
========================================
- Coverage 46.7% 46.7% -0.1%
========================================
Files 179 179
Lines 14202 14205 +3
========================================
Hits 6645 6645
- Misses 7557 7560 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
If a Place has multiple SSH targets, typing "labgrid-client ssh <net-name>" triggers an ambiguous "multiple targets" error. It's usually just a missing -n flag, so let's point the user in the right direction with a clearer hint in the logs. Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
429160d to
eb65054
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a Place has multiple SSH targets, typing "labgrid-client ssh " triggers an ambiguous "multiple targets" error. It's usually just a missing -n flag, so let's point the user in the right direction with a clearer hint in the logs.
I'm not sure if you could add this? IMHO the "multiple targets" as only error message can be a bit confusing. You may lose quite some time double-checking configs, for actually a subtle commandline mistake which easily can be identified at
the client, and just a little note like this could save you some time. Then, the next colleague comes up with the same issue again, and again.
Once you know how it works, you never will miss a "-n" again, and for sure this is not the biggest issue. I understand
all this and no problem if you drop this commit. No problem! Anyway, just think about it ;)