[DO NOT MERGE] feat(cli): add Markdown support for CLI - #1356
[DO NOT MERGE] feat(cli): add Markdown support for CLI#1356jasminesun-lw wants to merge 17 commits into
Conversation
Less aggressive vertical padding for timeline boxes ANEP-2048
|
@jasminesun-lw , can we add some screenshots to the description with before+after side-by-side rendering of plaintext comments? |
|
@jasminesun-lw , we will want and need some updated automated testing for this using the |
jasminesun-lw
changed the title
| ) | ||
|
|
||
| require ( | ||
| github.com/Delta456/box-cli-maker/v2 v2.3.0 |
There was a problem hiding this comment.
Are there packages cross platform compatible? Especially for windows?
There was a problem hiding this comment.
So box-cli-maker seems to render fine in windows command line. go-term-markdown is another story...
There was a problem hiding this comment.
For windows me might have to revert back to just showing a table (not sure how tables even look with really long comments today). I'm not aware of any go+markdown+windows-cli packages.
There was a problem hiding this comment.
We can maybe look into this...https://github.com/charmbracelet/glow
|
Check windows 🪟 |
|
Also, this is exciting!! |
|
@jasminesun-lw , this looks good to me. I'll let the GROW team weigh in on this as well. Can we also create a GROW Jira ticket to look into windows markdown rendering support? |
Done! It's currently in backlog: https://lacework.atlassian.net/browse/GROW-2399 |
|
Ping! |
afiune
left a comment
afiune
left a comment
There was a problem hiding this comment.
Tested locally! Works great on my Mac 🙌🏽
hazedav
changed the title
3 participants
Summary
Enhance Lacework’s Timeline/commenting functionality to better support investigation workflows, specifically by including the ability to leverage Markdown.
How did you test this change?
Demo video:
https://github.com/lacework/go-sdk/assets/132718757/239261c3-6b0c-4af1-bd48-cf27a0efea38
Before:
After:
Issue
https://lacework.atlassian.net/browse/ANEP-2048