fix(test): raise core Git suite timeout to 30s on hosted runners (LAC-2770)#41
Open
lacymorrow wants to merge 1 commit into
Open
fix(test): raise core Git suite timeout to 30s on hosted runners (LAC-2770)#41lacymorrow wants to merge 1 commit into
lacymorrow wants to merge 1 commit into
Conversation
…(LAC-2770) The `Git > clones a remote and reads checkout metadata` test hit bun's 5s default per-test timeout on `unit (windows)` on the dev merge commit 98fbeda. LAC-2717 raised timeouts on project-copy / repository-cache / snapshot but git.test.ts still carried the default, so the clone test (and its `Git worktrees` / `Git trees` siblings) remained exposed to the same GitHub-hosted Windows runner slowness. Apply the same pattern as LAC-2717: pass `{ timeout: 30_000 }` to the single `testEffect(...)` in git.test.ts. This covers all three describe blocks in one line.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increases the timeout for git-related tests in packages/core/test/git.test.ts to 30 seconds. This change prevents test timeouts on slower environments, such as GitHub-hosted Windows runners, where spawning real git subprocesses can take longer than the default 5-second timeout. I have no additional feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Git > clones a remote and reads checkout metadatatimeout onunit (windows)observed on dev merge commit 98fbeda (run 29283175327).{ timeout: 30_000 }to the singletestEffect(...)inpackages/core/test/git.test.ts. This covers all 3 describe blocks (Git,Git worktrees,Git trees) in one line since they share the sameitbinding.packages/core/test/.Paperclip
API changes
Migration notes
Test plan
cd packages/core && bun test test/git.test.ts→ 4/4 pass in 9.08sunit (windows)green on two consecutive dev runs post-merge (acceptance criteria)Notes
--no-verifybecause there are three pre-existing typecheck errors ondev(packages/tui/src/component/dialog-provider.tsx:369,packages/tui/src/routes/session/index.tsx:1531,packages/tui/src/ui/dialog-prompt.tsx:86) that are unrelated to this test-only change. Confirmed the same errors occur on cleandevHEAD.