Skip to content

fix: report builder & usage dialog review follow-ups#212

Merged
v-kessler merged 1 commit into
mainfrom
fix--review-followups
Jun 24, 2026
Merged

fix: report builder & usage dialog review follow-ups#212
v-kessler merged 1 commit into
mainfrom
fix--review-followups

Conversation

@v-kessler

Copy link
Copy Markdown
Contributor

Addresses CodeRabbit review findings from #210 (verified against merged code; minimal fixes).

Fixed

  • reports store — snapshot chartConfig on save/update so saved reports don't alias the live UI config.
  • ReportBuilderPanel — hide the Aggregation control for pie charts (pie uses raw values); detach mousemove/mouseup listeners on unmount if a resize is in progress; escape the user-supplied report name in the print/PDF window (XSS).
  • UsageDatumDialog — never export the plaintext bucket prefix while masking is on; shell-quote the storage endpoint in the generated script (command injection); log non-permission warehouse-list errors instead of swallowing all.

Skipped (with reason)

  • index.ts reports exports "bypass stores/index.ts" — invalid: useVisualStore/useNavigationStore are also exported directly from their store files in index.ts, so this already matches the real pattern.
  • UsageDatumDialog loadError should use handleError() — skipped: the dialog surfaces the error inline; a snackbar would be redundant/worse for a modal.
  • UsageDatumDialog missing useConfig() — skipped: config isn't used in this component; adding it is dead code.

BEGIN_COMMIT_OVERRIDE
fix(ui): snapshot saved report chartConfig so it does not alias live UI state
fix(ui): hide aggregation control for pie charts in the report builder
fix(ui): detach report-builder resize listeners on unmount
fix(ui): escape user report name in report builder print/PDF output
fix(ui): never export plaintext bucket prefix while masking in the usage dialog
fix(ui): shell-quote storage endpoint in the generated usage script
fix(ui): log non-permission warehouse-list errors in the usage dialog
END_COMMIT_OVERRIDE

- reports store: snapshot chartConfig on save/update so saved reports don't alias live UI state
- report builder: hide aggregation control for pie charts (pie uses raw values)
- report builder: detach resize listeners on unmount (no leak mid-drag)
- report builder: escape user report name in print/PDF output (XSS)
- usage dialog: never export the plaintext bucket prefix while masking
- usage dialog: shell-quote the storage endpoint in the generated script (injection)
- usage dialog: log non-permission warehouse-list errors instead of swallowing all

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 94b42215-2206-4feb-bd4c-5a4f5cb4f27c

📥 Commits

Reviewing files that changed from the base of the PR and between 33cf071 and f1b149b.

📒 Files selected for processing (3)
  • src/components/ReportBuilderPanel.vue
  • src/components/UsageDatumDialog.vue
  • src/stores/reports.ts
 _______________________________________________
< Somewhere, a linter just sighed dramatically. >
 -----------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix--review-followups

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@v-kessler v-kessler merged commit addcd8e into main Jun 24, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant