fix: report builder & usage dialog review follow-ups#212
Merged
Conversation
- reports store: snapshot chartConfig on save/update so saved reports don't alias live UI state - report builder: hide aggregation control for pie charts (pie uses raw values) - report builder: detach resize listeners on unmount (no leak mid-drag) - report builder: escape user report name in print/PDF output (XSS) - usage dialog: never export the plaintext bucket prefix while masking - usage dialog: shell-quote the storage endpoint in the generated script (injection) - usage dialog: log non-permission warehouse-list errors instead of swallowing all Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses CodeRabbit review findings from #210 (verified against merged code; minimal fixes).
Fixed
chartConfigon save/update so saved reports don't alias the live UI config.mousemove/mouseuplisteners on unmount if a resize is in progress; escape the user-supplied report name in the print/PDF window (XSS).Skipped (with reason)
index.tsreports exports "bypass stores/index.ts" — invalid:useVisualStore/useNavigationStoreare also exported directly from their store files inindex.ts, so this already matches the real pattern.loadErrorshould usehandleError()— skipped: the dialog surfaces the error inline; a snackbar would be redundant/worse for a modal.useConfig()— skipped:configisn't used in this component; adding it is dead code.BEGIN_COMMIT_OVERRIDE
fix(ui): snapshot saved report chartConfig so it does not alias live UI state
fix(ui): hide aggregation control for pie charts in the report builder
fix(ui): detach report-builder resize listeners on unmount
fix(ui): escape user report name in report builder print/PDF output
fix(ui): never export plaintext bucket prefix while masking in the usage dialog
fix(ui): shell-quote storage endpoint in the generated usage script
fix(ui): log non-permission warehouse-list errors in the usage dialog
END_COMMIT_OVERRIDE