Handle stable warning snapshots#500
Open
tdashelby-cmyk wants to merge 1 commit into
Open
Conversation
79dfd1d to
652a54d
Compare
Author
|
CI reran after the branch update. The warning-test job ( The remaining red job is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #498.
The warning tests compare trybuild stderr fixtures. The existing fixtures match the nightly diagnostic rendering used by the repository CI, while the Debian report shows the stable-style rendering for three diagnostics where help notes are printed before the source location.
This keeps the current nightly warning run unchanged and adds stable-specific fixtures for those three cases. On nightly, the test still runs
tests/warnings/*.rs; on non-nightly, it runs the unaffected warning cases plus the stable fixtures.Verification:
git diff --checkgit show --check --oneline HEADI could not run
cargo test -p maud --test errors run_warningslocally in this environment becausecargois not installed on PATH. The first CI run showed the original fixture replacement was wrong for nightly, so I amended this to keep the nightly fixtures unchanged and add non-nightly fixtures instead.