Harden VS Code conversion-create E2E flow#9
Open
lambrianmsft wants to merge 3 commits into
Open
Conversation
Fill the convert-to-workspace wizard by label instead of positional inputs and wait for validation before advancing to review. Add diagnostics and safer Next-click fallbacks so the test fails with actionable state instead of silently mixing field values. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the exact Create workspace footer button and a single DOM click so the review-step submit action is not confused with the Review + create stepper button or blocked by VS Code notifications. Keep the post-click assertion focused on the actual submit button state and workspace file creation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Guard follow-up label reads and container traversal in findInputByLabel so transient webview re-renders do not fail the conversion-create test with stale element errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation