-
Notifications
You must be signed in to change notification settings - Fork 729
feat: support HDFS object store #5472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hfutatzhanghb
wants to merge
21
commits into
lance-format:main
Choose a base branch
from
hfutatzhanghb:dev-hdfs-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
70fe27d
feat: lance supports hdfs scheme
a2cbc96
fix: exclude hdfs from CI all-features builds and update Cargo.lock
2cbc753
fix: improve optional HDFS handling
fc3d878
fix java build failed
dd5d0a8
docs: explain Java HDFS builds
3c34728
docs: use mvn in Java build examples
f1f3ba1
docs: document HDFS object store setup
330e010
docs: move HDFS configuration after TOS
af19ff3
optimize feature hdfs
aee5b6b
fix: filter empty string values in HDFS storage options
4155f24
refactor: remove duplicate test_hdfs_url_parsing integration test
2486617
docs: explain HDFS integration test opt-in
1df96ea
test: remove ineffective HDFS config validation
cc0cc65
test: explicitly ignore HDFS integration tests
535ab49
fix: set list_is_lexically_ordered to false for HDFS
988ad4b
fix: derive store_prefix from resolved effective NameNode for HDFS
87a6af7
feat: add safe HDFS rename commit handler via libhdfs
d87b8d5
style: fix cargo fmt issues in hdfs commit handler
1cc2215
test: add unit tests for HDFS commit handler helper functions
3de1e1b
fix: move StorageOptionsAccessor import into test module
3ac5474
chore: sync python/Cargo.lock with workspace hdrs dep
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not depend on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @Xuanwo . Do you mean we should avoid using hdrs directly and implement the HDFS commit rename through OpenDAL instead? My concern is preserving the rename-if-destination-does-not-exist semantics required for commit conflict detection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenDAL’s HDFS rename currently overwrites the destination by deleting it first. The manifest commit requires an atomic rename-if-destination-does-not-exist operation for conflict detection. Would you prefer adding conditional rename support to OpenDAL first, or is there another OpenDAL API intended for this semantic?