fix(index): drop stale scalar index entries after stable-row-id update#7359
Open
wkalt wants to merge 1 commit into
Open
fix(index): drop stale scalar index entries after stable-row-id update#7359wkalt wants to merge 1 commit into
wkalt wants to merge 1 commit into
Conversation
github-actions
Bot
added
A-index
Under stable row ids an update deletes a row's old copy and rewrites it to
a new fragment under the same row id. optimize_indices kept the old
value->row_id entry, so queries for the old value returned the updated row
and BTree optimize errored ("from_sorted_iter called with non-sorted
input").
- build_stable_row_id_filter now subtracts each fragment's deletion vector
so the old-row allow-list holds only live rows (fixes BTree).
- BitmapIndex::update applies that filter to old postings via
OldIndexDataFilter::retain_old_rows.
- optimize routes FTS through InvertedIndex::merge_segments (which filters
old partitions) instead of the reference-only update path.
Adds a regression test covering all three index types.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
wkalt
force-pushed
the
ticket/gen-640/stale-scalar-index-stable-rowid-update
branch
from
8ff2484 to
3d26238
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under stable row ids an update deletes a row's old copy and rewrites it to a new fragment under the same row id. optimize_indices kept the old value->row_id entry, so queries for the old value returned the updated row and BTree optimize errored ("from_sorted_iter called with non-sorted input").
Adds a regression test covering all three index types.