feat: add local SpillStore for index scratch#7369
Draft
RitwijParmar wants to merge 1 commit into
Draft
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds the generic local spill mechanism described in #7300 so future memory-budgeted index builders have a session-scoped place for reclaimable scratch files.
Changes include:
SpillStore/SpillFiletraits andLocalSpillStoreimplementation inlance-ioDiskQuotaaccounting wired into local writers for clean cap-exceeded errorsScanScheduler::open_readerfor already-open readersSessionwiring with a default local spill store and override hookThis intentionally does not migrate IVF consumers yet; that remains the follow-up slice from #7300.
Validation
cargo fmt --allcargo test -p lance-io spill --libcargo check -p lance-ioI also tried
cargo check -p lance, but the local environment is missingprotoc, solance-encodingbuild script stops before the top-level crate can finish.Refs #7300