fix: support Arrow ListView writes#7380
Draft
wirybeaver wants to merge 1 commit into
Draft
Conversation
Summary: - Normalize Arrow ListView and LargeListView schemas to Lance's offset-based List and LargeList types. - Downcast top-level list-view columns in the dataset write adapter. - Allow dictionary capture to inspect list-view child values before write conversion. - Add create and append round-trip coverage for list-view columns. Test Plan: - cargo fmt --all - git diff --check - cargo test -p lance-core test_view_types_stored_as_lance_base_types - PROTOC=/home/user/lance/target/debug/build/protobuf-src-0bbb645409253599/out/bin/protoc-27.2.0 cargo test -p lance --features "protoc lance-datafusion/protoc" list_view - cargo clippy -p lance-core --tests -- -D warnings - PROTOC=/home/user/lance/target/debug/build/protobuf-src-0bbb645409253599/out/bin/protoc-27.2.0 cargo clippy -p lance --features "protoc lance-datafusion/protoc" --tests -- -D warnings - PROTOC=/home/user/lance/target/debug/build/protobuf-src-0bbb645409253599/out/bin/protoc-27.2.0 cargo clippy --all --tests --benches -- -D warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListViewandLargeListViewschemas to Lance offset-basedListandLargeListtypes.Related: #7069 task 3.
Test Plan
cargo fmt --allgit diff --checkcargo test -p lance-core test_view_types_stored_as_lance_base_typesPROTOC=/home/user/lance/target/debug/build/protobuf-src-0bbb645409253599/out/bin/protoc-27.2.0 cargo test -p lance --features "protoc lance-datafusion/protoc" list_viewcargo clippy -p lance-core --tests -- -D warningsPROTOC=/home/user/lance/target/debug/build/protobuf-src-0bbb645409253599/out/bin/protoc-27.2.0 cargo clippy -p lance --features "protoc lance-datafusion/protoc" --tests -- -D warningsPROTOC=/home/user/lance/target/debug/build/protobuf-src-0bbb645409253599/out/bin/protoc-27.2.0 cargo clippy --all --tests --benches -- -D warnings