fix: get_subgraphs prefix matching with shared node name prefixes#7240
Open
r266-tech wants to merge 1 commit intolangchain-ai:mainfrom
Open
fix: get_subgraphs prefix matching with shared node name prefixes#7240r266-tech wants to merge 1 commit intolangchain-ai:mainfrom
r266-tech wants to merge 1 commit intolangchain-ai:mainfrom
Conversation
Fixes a bug where get_subgraphs() would fail when two sibling nodes share a common name prefix (e.g. 'common_prefix' and 'common_prefix_2'). The root cause was using startswith() without checking the namespace separator boundary. When looking up namespace 'common_prefix_2|x', the node 'common_prefix' would incorrectly match (since the string 'common_prefix_2|x' starts with 'common_prefix'), then the namespace would be corrupted by stripping 'common_prefix|' from it, leaving '2|x' which matches nothing. Fix: check that the match includes the full segment boundary by verifying namespace == name or namespace.startswith(name + NS_SEP). Fixes langchain-ai#6924
7 tasks
Contributor
|
This PR has been automatically closed because you are not assigned to the linked issue. External contributors must be assigned to an issue before opening a PR for it. Please:
Maintainers: reopen this PR or remove the |
Mason Daugherty (mdrxy)
added
bypass-issue-check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in Pregel.get_subgraphs() where nodes sharing a common name prefix cause incorrect namespace resolution.
Problem
When looking up namespace common_prefix_2|child_subgraph, the startswith check incorrectly matches node common_prefix, corrupting the namespace.
Root Cause
The prefix filter used namespace.startswith(name) without checking the separator boundary.
Fix
Changed the filter to verify the full segment boundary.
Closes #6924