fix(workflow): use correct field ID in KB metadata filter selection#34149
Open
shawny011717 wants to merge 1 commit intolanggenius:mainfrom
Open
fix(workflow): use correct field ID in KB metadata filter selection#34149shawny011717 wants to merge 1 commit intolanggenius:mainfrom
shawny011717 wants to merge 1 commit intolanggenius:mainfrom
Conversation
Move onClick handler from inner text div to the outer row div in the metadata field dropdown. The handler was previously attached only to the name label, causing clicks on other parts of the row (icon, type label, padding) to not register the correct selection. Fixes langgenius#33577.
dosubot
Bot
added
the
size:XS
Author
|
Gentle ping — this one's been waiting ~3 weeks for review. Happy to rebase or break it into smaller diffs if that helps. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Fixes #33577.
The
onClickhandler in the metadata field dropdown (AddConditioncomponent) was attached to the inner text<div>instead of the outer row<div>. This meant clicks landing on the icon, type label, or row padding did not register the intended field — the resulting mis-hit caused the UI to appear to always select the first field. Moving the handler to the row element ensures the full clickable area maps to the correct metadata item.Screenshots
N/A (logic-only fix, no visual change)
Checklist
cd web && npx lint-stagedto appease the lint gods