Skip to content

refactor: core/rag docstore, datasource, embedding, rerank, retrieval#34203

Open
RenzoMXD wants to merge 4 commits intolanggenius:mainfrom
RenzoMXD:refactor/select-core-rag
Open

refactor: core/rag docstore, datasource, embedding, rerank, retrieval#34203
RenzoMXD wants to merge 4 commits intolanggenius:mainfrom
RenzoMXD:refactor/select-core-rag

Conversation

@RenzoMXD
Copy link
Copy Markdown
Contributor

@RenzoMXD RenzoMXD commented Mar 27, 2026

Summary

  • Migrate 19 db.session.query() calls to SQLAlchemy 2.0 select() style across 12 files in core/rag/
  • Use session.get() for PK lookups (UploadFile, ToolFile), scalar(select(...).limit(1)) for non-PK filtered queries (Embedding, TidbAuthBinding), scalars(select(...)) for multi-row queries, execute(delete(...)) for bulk deletes, and execute(update(...)) for bulk updates
  • Update test mock wiring in 12 test files (mock plumbing only — no test logic or assertion changes)

Test plan

  • make type-check passes for all 12 changed source files (basedpyright)
  • All 1449 core/rag/ unit tests pass (0 failures, matching clean main)

Note on test changes

Test files only re-wire mock setup to match new query patterns. No test logic or assertions were modified.

Part of #22668

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. refactor labels Mar 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Pyrefly Diff

base → PR 
--- /tmp/pyrefly_base.txt	2026-03-27 15:21:58.988403583 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-27 15:21:48.641307969 +0000
@@ -262,13 +262,13 @@
 ERROR Unpacked keyword argument `bool | float | int | str | None` is not assignable to parameter `auth_token_provider` with type `(() -> Awaitable[str]) | (() -> str) | None` in function `qdrant_client.qdrant_client.QdrantClient.__init__` [bad-argument-type]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:87:51
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:40
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:449:40
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:42
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:42
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:37
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:37
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:453:38
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:38
 ERROR `None` is not subscriptable [unsupported-operation]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_service.py:62:20
 ERROR `None` is not subscriptable [unsupported-operation]
@@ -286,15 +286,15 @@
 ERROR `response` may be uninitialized [unbound-name]
    --> core/rag/extractor/firecrawl/firecrawl_app.py:193:16
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.post` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:105:25
+   --> core/rag/extractor/notion_extractor.py:107:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:174:29
+   --> core/rag/extractor/notion_extractor.py:176:29
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:236:25
+   --> core/rag/extractor/notion_extractor.py:238:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:296:25
+   --> core/rag/extractor/notion_extractor.py:298:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:368:21
+   --> core/rag/extractor/notion_extractor.py:372:21
 ERROR Cannot index into `Generator[Unknown]` [bad-index]
    --> core/rag/extractor/watercrawl/client.py:210:54
 ERROR Cannot index into `bytes` [bad-index]
@@ -341,9 +341,9 @@
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/paragraph_index_processor.py:199:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:234:33
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:239:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:235:16
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:240:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/qa_index_processor.py:204:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
@@ -4622,43 +4622,43 @@
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
    --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:203:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:24
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:231:24
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:239:26
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:26
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:249:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:245:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:260:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:256:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:272:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:280:42
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:294:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:290:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:310:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:306:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:324:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:320:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:346:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:342:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:366:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:362:21
 ERROR Object of class `FunctionType` has no attribute `assert_called_once_with` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:372:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:368:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:369:5
 ERROR Object of class `FunctionType` has no attribute `reset_mock` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:375:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:371:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:381:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:21
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:393:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:389:25
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:394:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:390:25
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:400:19
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:396:19
 ERROR Object of class `ModuleType` has no attribute `analyse` [missing-attribute]
   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba_keyword_table_handler.py:30:5
 ERROR Object of class `ModuleType` has no attribute `default_tfidf` [missing-attribute]
@@ -5112,7 +5112,7 @@
 ERROR Argument `list[str]` is not assignable to parameter `docs` with type `Sequence[Document]` in function `core.rag.docstore.dataset_docstore.DatasetDocumentStore.add_documents` [bad-argument-type]
    --> tests/unit_tests/core/rag/docstore/test_dataset_docstore.py:307:37
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:304:85
+   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:293:85
 ERROR Object of class `PartialImpl` has no attribute `embed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:127:13
 ERROR Object of class `PartialImpl` has no attribute `embed_documents` [missing-attribute]
@@ -5126,9 +5126,9 @@
 ERROR Object of class `PartialImpl` has no attribute `aembed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:218:23
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:571:85
+   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:559:85
 ERROR Argument `list[LiteralString]` is not assignable to parameter `texts` with type `list[str]` in function `core.rag.embedding.cached_embedding.CacheEmbedding.embed_documents` [bad-argument-type]
-    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1334:54
+    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1322:54
 ERROR Class member `_ManagedStringIO.__exit__` overrides parent class `StringIO` in an inconsistent manner [bad-param-name-override]
   --> tests/unit_tests/core/rag/extractor/test_csv_extractor.py:16:9
 ERROR Argument `SimpleNamespace` is not assignable to parameter `upload_file` with type `UploadFile` in function `core.rag.extractor.extract_processor.ExtractProcessor.load_from_upload_file` [bad-argument-type]
@@ -5154,7 +5154,7 @@
 ERROR Object of class `NoneType` has no attribute `strip` [missing-attribute]
   --> tests/unit_tests/core/rag/extractor/test_markdown_extractor.py:30:16
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document_model` with type `Document | None` in function `core.rag.extractor.notion_extractor.NotionExtractor.update_last_edited_time` [bad-argument-type]
-   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:434:43
+   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:435:43
 ERROR Type `object` is not iterable [not-iterable]
   --> tests/unit_tests/core/rag/extractor/test_word_extractor.py:90:9
 ERROR `Any | None` is not assignable to attribute `FILES_URL` with type `str` [bad-assignment]
@@ -5174,11 +5174,11 @@
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.paragraph_index_processor.ParagraphIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_paragraph_index_processor.py:241:39
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor.retrieve` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:312:39
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:305:39
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:322:88
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:315:88
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:340:63
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:333:63
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.qa_index_processor.QAIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_qa_index_processor.py:267:39
 ERROR Missing required key `enable` for TypedDict `SummaryIndexSettingDict` [bad-typed-dict-key]
@@ -5192,13 +5192,13 @@
 ERROR Argument `Literal['completed']` is not assignable to parameter `after_indexing_status` with type `IndexingStatus` in function `core.indexing_runner.IndexingRunner._update_document_index_status` [bad-argument-type]
     --> tests/unit_tests/core/rag/indexing/test_indexing_runner.py:1071:71
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1587:9
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1578:9
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1588:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1579:16
 ERROR Object of class `FunctionType` has no attribute `call_count` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1639:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1630:16
 ERROR No matching overload found for function `_pytest.raises.raises` called with arguments: (tuple[type[TypeError], type[AttributeError]]) [no-matching-overload]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1846:31
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1837:31
 ERROR Argument `list[float] | None` is not assignable to parameter `obj` with type `Sized` in function `len` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:1951:20
 ERROR Could not find name `metadata_name` [unknown-name]
@@ -5210,29 +5210,29 @@
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval._handle_invoke_result` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:3788:67
 ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4028:16
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4027:16
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4562:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4561:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4614:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4613:40
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4619:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4618:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4635:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4634:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4665:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4664:36
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4670:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4669:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4678:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4677:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4714:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4713:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4742:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4741:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4800:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4799:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4844:44
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4843:44
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.router.multi_dataset_react_route.ReactMultiDatasetRouter._handle_invoke_result` [bad-argument-type]
    --> tests/unit_tests/core/rag/retrieval/test_multi_dataset_react_route.py:198:52
 ERROR Argument `None` is not assignable to parameter `text` with type `str` in function `core.rag.splitter.text_splitter.RecursiveCharacterTextSplitter.split_text` [bad-argument-type]

@asukaminato0721 asukaminato0721 requested a review from Copilot March 27, 2026 15:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Pyrefly Diff

base → PR 
--- /tmp/pyrefly_base.txt	2026-03-27 15:23:56.909453186 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-27 15:23:46.624088495 +0000
@@ -262,13 +262,13 @@
 ERROR Unpacked keyword argument `bool | float | int | str | None` is not assignable to parameter `auth_token_provider` with type `(() -> Awaitable[str]) | (() -> str) | None` in function `qdrant_client.qdrant_client.QdrantClient.__init__` [bad-argument-type]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:87:51
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:40
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:449:40
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:42
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:42
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:37
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:37
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:453:38
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:38
 ERROR `None` is not subscriptable [unsupported-operation]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_service.py:62:20
 ERROR `None` is not subscriptable [unsupported-operation]
@@ -286,15 +286,15 @@
 ERROR `response` may be uninitialized [unbound-name]
    --> core/rag/extractor/firecrawl/firecrawl_app.py:193:16
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.post` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:105:25
+   --> core/rag/extractor/notion_extractor.py:106:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:174:29
+   --> core/rag/extractor/notion_extractor.py:175:29
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:236:25
+   --> core/rag/extractor/notion_extractor.py:237:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:296:25
+   --> core/rag/extractor/notion_extractor.py:297:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:368:21
+   --> core/rag/extractor/notion_extractor.py:371:21
 ERROR Cannot index into `Generator[Unknown]` [bad-index]
    --> core/rag/extractor/watercrawl/client.py:210:54
 ERROR Cannot index into `bytes` [bad-index]
@@ -341,9 +341,9 @@
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/paragraph_index_processor.py:199:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:234:33
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:239:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:235:16
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:240:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/qa_index_processor.py:204:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
@@ -4622,43 +4622,43 @@
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
    --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:203:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:24
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:231:24
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:239:26
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:26
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:249:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:245:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:260:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:256:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:272:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:280:42
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:294:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:290:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:310:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:306:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:324:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:320:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:346:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:342:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:366:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:362:21
 ERROR Object of class `FunctionType` has no attribute `assert_called_once_with` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:372:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:368:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:369:5
 ERROR Object of class `FunctionType` has no attribute `reset_mock` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:375:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:371:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:381:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:21
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:393:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:389:25
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:394:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:390:25
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:400:19
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:396:19
 ERROR Object of class `ModuleType` has no attribute `analyse` [missing-attribute]
   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba_keyword_table_handler.py:30:5
 ERROR Object of class `ModuleType` has no attribute `default_tfidf` [missing-attribute]
@@ -5112,7 +5112,7 @@
 ERROR Argument `list[str]` is not assignable to parameter `docs` with type `Sequence[Document]` in function `core.rag.docstore.dataset_docstore.DatasetDocumentStore.add_documents` [bad-argument-type]
    --> tests/unit_tests/core/rag/docstore/test_dataset_docstore.py:307:37
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:304:85
+   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:293:85
 ERROR Object of class `PartialImpl` has no attribute `embed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:127:13
 ERROR Object of class `PartialImpl` has no attribute `embed_documents` [missing-attribute]
@@ -5126,9 +5126,9 @@
 ERROR Object of class `PartialImpl` has no attribute `aembed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:218:23
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:571:85
+   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:559:85
 ERROR Argument `list[LiteralString]` is not assignable to parameter `texts` with type `list[str]` in function `core.rag.embedding.cached_embedding.CacheEmbedding.embed_documents` [bad-argument-type]
-    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1334:54
+    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1322:54
 ERROR Class member `_ManagedStringIO.__exit__` overrides parent class `StringIO` in an inconsistent manner [bad-param-name-override]
   --> tests/unit_tests/core/rag/extractor/test_csv_extractor.py:16:9
 ERROR Argument `SimpleNamespace` is not assignable to parameter `upload_file` with type `UploadFile` in function `core.rag.extractor.extract_processor.ExtractProcessor.load_from_upload_file` [bad-argument-type]
@@ -5154,7 +5154,7 @@
 ERROR Object of class `NoneType` has no attribute `strip` [missing-attribute]
   --> tests/unit_tests/core/rag/extractor/test_markdown_extractor.py:30:16
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document_model` with type `Document | None` in function `core.rag.extractor.notion_extractor.NotionExtractor.update_last_edited_time` [bad-argument-type]
-   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:434:43
+   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:435:43
 ERROR Type `object` is not iterable [not-iterable]
   --> tests/unit_tests/core/rag/extractor/test_word_extractor.py:90:9
 ERROR `Any | None` is not assignable to attribute `FILES_URL` with type `str` [bad-assignment]
@@ -5174,11 +5174,11 @@
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.paragraph_index_processor.ParagraphIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_paragraph_index_processor.py:241:39
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor.retrieve` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:312:39
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:305:39
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:322:88
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:315:88
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:340:63
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:333:63
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.qa_index_processor.QAIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_qa_index_processor.py:267:39
 ERROR Missing required key `enable` for TypedDict `SummaryIndexSettingDict` [bad-typed-dict-key]
@@ -5192,13 +5192,13 @@
 ERROR Argument `Literal['completed']` is not assignable to parameter `after_indexing_status` with type `IndexingStatus` in function `core.indexing_runner.IndexingRunner._update_document_index_status` [bad-argument-type]
     --> tests/unit_tests/core/rag/indexing/test_indexing_runner.py:1071:71
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1587:9
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1578:9
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1588:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1579:16
 ERROR Object of class `FunctionType` has no attribute `call_count` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1639:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1630:16
 ERROR No matching overload found for function `_pytest.raises.raises` called with arguments: (tuple[type[TypeError], type[AttributeError]]) [no-matching-overload]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1846:31
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1837:31
 ERROR Argument `list[float] | None` is not assignable to parameter `obj` with type `Sized` in function `len` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:1951:20
 ERROR Could not find name `metadata_name` [unknown-name]
@@ -5210,29 +5210,29 @@
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval._handle_invoke_result` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:3788:67
 ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4028:16
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4027:16
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4562:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4561:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4614:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4613:40
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4619:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4618:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4635:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4634:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4665:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4664:36
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4670:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4669:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4678:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4677:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4714:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4713:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4742:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4741:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4800:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4799:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4844:44
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4843:44
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.router.multi_dataset_react_route.ReactMultiDatasetRouter._handle_invoke_result` [bad-argument-type]
    --> tests/unit_tests/core/rag/retrieval/test_multi_dataset_react_route.py:198:52
 ERROR Argument `None` is not assignable to parameter `text` with type `str` in function `core.rag.splitter.text_splitter.RecursiveCharacterTextSplitter.split_text` [bad-argument-type]

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 27, 2026
Copilot AI reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors core/rag/ SQLAlchemy ORM usage to the SQLAlchemy 2.0 select()/scalars()/scalar()/session.get() APIs to improve typing and align with the 2.0 query style, and updates unit tests’ mocks accordingly.

Changes:

  • Migrated ORM reads from db.session.query(...) to select(...) + scalars()/scalar() and PK lookups to session.get().
  • Replaced some ORM bulk operations with Core delete()/update() executed via session.execute(...).
  • Rewired unit test mocks to match the new session methods (scalars, scalar, get, execute).

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
api/core/rag/retrieval/dataset_retrieval.py Switch metadata-filter document lookup to select(...) + session.scalars(...).
api/core/rag/rerank/rerank_model.py Use session.get() for UploadFile PK fetches in multimodal rerank paths.
api/core/rag/index_processor/processor/parent_child_index_processor.py Replace child-id query + bulk deletes with select/delete executed via session.execute(...).
api/core/rag/index_processor/processor/paragraph_index_processor.py Convert segment/upload-file queries to select(...) + session.scalars(...).
api/core/rag/index_processor/index_processor_base.py Convert upload-file multi-fetch to select(...) + session.scalars(...) and tool-file lookup to session.get().
api/core/rag/extractor/notion_extractor.py Replace query(...).update(...) with session.execute(update(...)).
api/core/rag/embedding/cached_embedding.py Replace embedding cache first() lookups with session.scalar(select(...).limit(1)).
api/core/rag/docstore/dataset_docstore.py Migrate max-position scalar query and child-chunk deletion to select/scalar + execute(delete(...)).
api/core/rag/datasource/vdb/vector_factory.py Use session.get() for UploadFile PK lookup in search_by_file.
api/core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py Replace idle-binding fetch with session.scalar(select(...).limit(1)).
api/core/rag/datasource/retrieval_service.py Convert dataset document batch fetch to select(...) + session.scalars(...).
api/core/rag/datasource/keyword/jieba/jieba.py Convert segment fetch to select(...) + session.scalars(...).
api/tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py Update mocks from query().where().all() to session.scalars(...).all().
api/tests/unit_tests/core/rag/rerank/test_reranker.py Update mocks from query().where().first() to session.get(...).
api/tests/unit_tests/core/rag/indexing/test_index_processor_base.py Update mocks for scalars(...) and get(...) usage.
api/tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py Update mocks/assertions for session.execute(delete(...)) and session.execute(select(...)).
api/tests/unit_tests/core/rag/indexing/processor/test_paragraph_index_processor.py Update mocks to session.scalars(...).all() for segment/upload-file loads.
api/tests/unit_tests/core/rag/extractor/test_notion_extractor.py Update mocks to validate session.execute(update(...)) path.
api/tests/unit_tests/core/rag/embedding/test_embedding_service.py Update cache lookup mocks from query().filter_by().first() to session.scalar(...).
api/tests/unit_tests/core/rag/embedding/test_cached_embedding.py Update cache lookup mocks from query().filter_by().first() to session.scalar(...).
api/tests/unit_tests/core/rag/docstore/test_dataset_docstore.py Update max-position and delete mocks to session.scalar(...) / session.execute(...).
api/tests/unit_tests/core/rag/datasource/vdb/test_vector_factory.py Update upload-file lookup mocks to session.get(...).
api/tests/unit_tests/core/rag/datasource/test_datasource_retrieval.py Update mocks to use session.scalars(...) and error path to raise from scalars.
api/tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py Update mocks to use session.scalars(...).all() and stub select(...).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@asukaminato0721 asukaminato0721 added this pull request to the merge queue Mar 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Pyrefly Diff

base → PR 
--- /tmp/pyrefly_base.txt	2026-03-27 16:04:41.318876311 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-27 16:04:30.721859281 +0000
@@ -262,13 +262,13 @@
 ERROR Unpacked keyword argument `bool | float | int | str | None` is not assignable to parameter `auth_token_provider` with type `(() -> Awaitable[str]) | (() -> str) | None` in function `qdrant_client.qdrant_client.QdrantClient.__init__` [bad-argument-type]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:87:51
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:40
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:449:40
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:42
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:42
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:37
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:37
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:453:38
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:38
 ERROR `None` is not subscriptable [unsupported-operation]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_service.py:62:20
 ERROR `None` is not subscriptable [unsupported-operation]
@@ -286,15 +286,15 @@
 ERROR `response` may be uninitialized [unbound-name]
    --> core/rag/extractor/firecrawl/firecrawl_app.py:193:16
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.post` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:105:25
+   --> core/rag/extractor/notion_extractor.py:106:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:174:29
+   --> core/rag/extractor/notion_extractor.py:175:29
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:236:25
+   --> core/rag/extractor/notion_extractor.py:237:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:296:25
+   --> core/rag/extractor/notion_extractor.py:297:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:368:21
+   --> core/rag/extractor/notion_extractor.py:371:21
 ERROR Cannot index into `Generator[Unknown]` [bad-index]
    --> core/rag/extractor/watercrawl/client.py:210:54
 ERROR Cannot index into `bytes` [bad-index]
@@ -341,9 +341,9 @@
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/paragraph_index_processor.py:199:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:234:33
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:239:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:235:16
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:240:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/qa_index_processor.py:204:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
@@ -4622,43 +4622,43 @@
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
    --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:203:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:24
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:231:24
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:239:26
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:26
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:249:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:245:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:260:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:256:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:272:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:280:42
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:294:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:290:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:310:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:306:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:324:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:320:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:346:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:342:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:366:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:362:21
 ERROR Object of class `FunctionType` has no attribute `assert_called_once_with` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:372:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:368:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:369:5
 ERROR Object of class `FunctionType` has no attribute `reset_mock` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:375:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:371:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:381:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:21
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:393:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:389:25
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:394:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:390:25
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:400:19
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:396:19
 ERROR Object of class `ModuleType` has no attribute `analyse` [missing-attribute]
   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba_keyword_table_handler.py:30:5
 ERROR Object of class `ModuleType` has no attribute `default_tfidf` [missing-attribute]
@@ -5112,7 +5112,7 @@
 ERROR Argument `list[str]` is not assignable to parameter `docs` with type `Sequence[Document]` in function `core.rag.docstore.dataset_docstore.DatasetDocumentStore.add_documents` [bad-argument-type]
    --> tests/unit_tests/core/rag/docstore/test_dataset_docstore.py:307:37
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:304:85
+   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:293:85
 ERROR Object of class `PartialImpl` has no attribute `embed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:127:13
 ERROR Object of class `PartialImpl` has no attribute `embed_documents` [missing-attribute]
@@ -5126,9 +5126,9 @@
 ERROR Object of class `PartialImpl` has no attribute `aembed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:218:23
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:571:85
+   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:559:85
 ERROR Argument `list[LiteralString]` is not assignable to parameter `texts` with type `list[str]` in function `core.rag.embedding.cached_embedding.CacheEmbedding.embed_documents` [bad-argument-type]
-    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1334:54
+    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1322:54
 ERROR Class member `_ManagedStringIO.__exit__` overrides parent class `StringIO` in an inconsistent manner [bad-param-name-override]
   --> tests/unit_tests/core/rag/extractor/test_csv_extractor.py:16:9
 ERROR Argument `SimpleNamespace` is not assignable to parameter `upload_file` with type `UploadFile` in function `core.rag.extractor.extract_processor.ExtractProcessor.load_from_upload_file` [bad-argument-type]
@@ -5154,7 +5154,7 @@
 ERROR Object of class `NoneType` has no attribute `strip` [missing-attribute]
   --> tests/unit_tests/core/rag/extractor/test_markdown_extractor.py:30:16
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document_model` with type `Document | None` in function `core.rag.extractor.notion_extractor.NotionExtractor.update_last_edited_time` [bad-argument-type]
-   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:434:43
+   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:435:43
 ERROR Type `object` is not iterable [not-iterable]
   --> tests/unit_tests/core/rag/extractor/test_word_extractor.py:90:9
 ERROR `Any | None` is not assignable to attribute `FILES_URL` with type `str` [bad-assignment]
@@ -5174,11 +5174,11 @@
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.paragraph_index_processor.ParagraphIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_paragraph_index_processor.py:241:39
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor.retrieve` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:312:39
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:305:39
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:322:88
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:315:88
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:340:63
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:333:63
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.qa_index_processor.QAIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_qa_index_processor.py:267:39
 ERROR Missing required key `enable` for TypedDict `SummaryIndexSettingDict` [bad-typed-dict-key]
@@ -5192,13 +5192,13 @@
 ERROR Argument `Literal['completed']` is not assignable to parameter `after_indexing_status` with type `IndexingStatus` in function `core.indexing_runner.IndexingRunner._update_document_index_status` [bad-argument-type]
     --> tests/unit_tests/core/rag/indexing/test_indexing_runner.py:1071:71
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1587:9
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1578:9
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1588:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1579:16
 ERROR Object of class `FunctionType` has no attribute `call_count` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1639:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1630:16
 ERROR No matching overload found for function `_pytest.raises.raises` called with arguments: (tuple[type[TypeError], type[AttributeError]]) [no-matching-overload]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1846:31
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1837:31
 ERROR Argument `list[float] | None` is not assignable to parameter `obj` with type `Sized` in function `len` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:1951:20
 ERROR Could not find name `metadata_name` [unknown-name]
@@ -5210,29 +5210,29 @@
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval._handle_invoke_result` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:3788:67
 ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4028:16
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4027:16
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4562:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4561:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4614:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4613:40
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4619:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4618:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4635:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4634:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4665:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4664:36
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4670:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4669:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4678:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4677:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4714:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4713:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4742:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4741:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4800:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4799:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4844:44
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4843:44
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.router.multi_dataset_react_route.ReactMultiDatasetRouter._handle_invoke_result` [bad-argument-type]
    --> tests/unit_tests/core/rag/retrieval/test_multi_dataset_react_route.py:198:52
 ERROR Argument `None` is not assignable to parameter `text` with type `str` in function `core.rag.splitter.text_splitter.RecursiveCharacterTextSplitter.split_text` [bad-argument-type]

auto-merge was automatically disabled March 27, 2026 16:39

Head branch was pushed to by a user without write access

@RenzoMXD RenzoMXD force-pushed the refactor/select-core-rag branch from 7b1b3db to ee64b35 Compare March 27, 2026 16:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Pyrefly Diff

base → PR 
--- /tmp/pyrefly_base.txt	2026-03-27 16:40:34.767083194 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-27 16:40:23.957981305 +0000
@@ -262,13 +262,13 @@
 ERROR Unpacked keyword argument `bool | float | int | str | None` is not assignable to parameter `auth_token_provider` with type `(() -> Awaitable[str]) | (() -> str) | None` in function `qdrant_client.qdrant_client.QdrantClient.__init__` [bad-argument-type]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:87:51
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:40
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:449:40
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:42
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:42
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:37
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:37
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:453:38
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:38
 ERROR `None` is not subscriptable [unsupported-operation]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_service.py:62:20
 ERROR `None` is not subscriptable [unsupported-operation]
@@ -286,15 +286,15 @@
 ERROR `response` may be uninitialized [unbound-name]
    --> core/rag/extractor/firecrawl/firecrawl_app.py:193:16
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.post` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:105:25
+   --> core/rag/extractor/notion_extractor.py:107:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:174:29
+   --> core/rag/extractor/notion_extractor.py:176:29
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:236:25
+   --> core/rag/extractor/notion_extractor.py:238:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:296:25
+   --> core/rag/extractor/notion_extractor.py:298:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:368:21
+   --> core/rag/extractor/notion_extractor.py:372:21
 ERROR Cannot index into `Generator[Unknown]` [bad-index]
    --> core/rag/extractor/watercrawl/client.py:210:54
 ERROR Cannot index into `bytes` [bad-index]
@@ -341,9 +341,9 @@
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/paragraph_index_processor.py:199:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:234:33
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:239:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:235:16
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:240:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/qa_index_processor.py:204:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
@@ -4622,43 +4622,43 @@
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
    --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:203:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:24
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:231:24
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:239:26
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:26
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:249:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:245:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:260:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:256:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:272:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:280:42
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:294:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:290:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:310:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:306:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:324:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:320:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:346:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:342:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:366:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:362:21
 ERROR Object of class `FunctionType` has no attribute `assert_called_once_with` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:372:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:368:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:369:5
 ERROR Object of class `FunctionType` has no attribute `reset_mock` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:375:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:371:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:381:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:21
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:393:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:389:25
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:394:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:390:25
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:400:19
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:396:19
 ERROR Object of class `ModuleType` has no attribute `analyse` [missing-attribute]
   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba_keyword_table_handler.py:30:5
 ERROR Object of class `ModuleType` has no attribute `default_tfidf` [missing-attribute]
@@ -5112,7 +5112,7 @@
 ERROR Argument `list[str]` is not assignable to parameter `docs` with type `Sequence[Document]` in function `core.rag.docstore.dataset_docstore.DatasetDocumentStore.add_documents` [bad-argument-type]
    --> tests/unit_tests/core/rag/docstore/test_dataset_docstore.py:307:37
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:304:85
+   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:293:85
 ERROR Object of class `PartialImpl` has no attribute `embed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:127:13
 ERROR Object of class `PartialImpl` has no attribute `embed_documents` [missing-attribute]
@@ -5126,9 +5126,9 @@
 ERROR Object of class `PartialImpl` has no attribute `aembed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:218:23
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:571:85
+   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:559:85
 ERROR Argument `list[LiteralString]` is not assignable to parameter `texts` with type `list[str]` in function `core.rag.embedding.cached_embedding.CacheEmbedding.embed_documents` [bad-argument-type]
-    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1334:54
+    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1322:54
 ERROR Class member `_ManagedStringIO.__exit__` overrides parent class `StringIO` in an inconsistent manner [bad-param-name-override]
   --> tests/unit_tests/core/rag/extractor/test_csv_extractor.py:16:9
 ERROR Argument `SimpleNamespace` is not assignable to parameter `upload_file` with type `UploadFile` in function `core.rag.extractor.extract_processor.ExtractProcessor.load_from_upload_file` [bad-argument-type]
@@ -5154,7 +5154,7 @@
 ERROR Object of class `NoneType` has no attribute `strip` [missing-attribute]
   --> tests/unit_tests/core/rag/extractor/test_markdown_extractor.py:30:16
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document_model` with type `Document | None` in function `core.rag.extractor.notion_extractor.NotionExtractor.update_last_edited_time` [bad-argument-type]
-   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:434:43
+   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:435:43
 ERROR Type `object` is not iterable [not-iterable]
   --> tests/unit_tests/core/rag/extractor/test_word_extractor.py:90:9
 ERROR `Any | None` is not assignable to attribute `FILES_URL` with type `str` [bad-assignment]
@@ -5174,11 +5174,11 @@
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.paragraph_index_processor.ParagraphIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_paragraph_index_processor.py:241:39
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor.retrieve` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:312:39
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:305:39
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:322:88
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:315:88
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:340:63
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:333:63
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.qa_index_processor.QAIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_qa_index_processor.py:267:39
 ERROR Missing required key `enable` for TypedDict `SummaryIndexSettingDict` [bad-typed-dict-key]
@@ -5192,13 +5192,13 @@
 ERROR Argument `Literal['completed']` is not assignable to parameter `after_indexing_status` with type `IndexingStatus` in function `core.indexing_runner.IndexingRunner._update_document_index_status` [bad-argument-type]
     --> tests/unit_tests/core/rag/indexing/test_indexing_runner.py:1071:71
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1587:9
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1578:9
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1588:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1579:16
 ERROR Object of class `FunctionType` has no attribute `call_count` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1639:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1630:16
 ERROR No matching overload found for function `_pytest.raises.raises` called with arguments: (tuple[type[TypeError], type[AttributeError]]) [no-matching-overload]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1846:31
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1837:31
 ERROR Argument `list[float] | None` is not assignable to parameter `obj` with type `Sized` in function `len` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:1951:20
 ERROR Could not find name `metadata_name` [unknown-name]
@@ -5210,29 +5210,29 @@
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval._handle_invoke_result` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:3788:67
 ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4028:16
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4027:16
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4562:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4561:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4614:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4613:40
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4619:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4618:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4635:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4634:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4665:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4664:36
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4670:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4669:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4678:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4677:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4714:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4713:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4742:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4741:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4800:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4799:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4844:44
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4843:44
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.router.multi_dataset_react_route.ReactMultiDatasetRouter._handle_invoke_result` [bad-argument-type]
    --> tests/unit_tests/core/rag/retrieval/test_multi_dataset_react_route.py:198:52
 ERROR Argument `None` is not assignable to parameter `text` with type `str` in function `core.rag.splitter.text_splitter.RecursiveCharacterTextSplitter.split_text` [bad-argument-type]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Pyrefly Diff

base → PR 
--- /tmp/pyrefly_base.txt	2026-03-27 16:40:36.291237869 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-27 16:40:25.545235020 +0000
@@ -262,13 +262,13 @@
 ERROR Unpacked keyword argument `bool | float | int | str | None` is not assignable to parameter `auth_token_provider` with type `(() -> Awaitable[str]) | (() -> str) | None` in function `qdrant_client.qdrant_client.QdrantClient.__init__` [bad-argument-type]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:87:51
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:40
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:449:40
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:42
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:42
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:37
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:37
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:453:38
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:38
 ERROR `None` is not subscriptable [unsupported-operation]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_service.py:62:20
 ERROR `None` is not subscriptable [unsupported-operation]
@@ -286,15 +286,15 @@
 ERROR `response` may be uninitialized [unbound-name]
    --> core/rag/extractor/firecrawl/firecrawl_app.py:193:16
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.post` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:105:25
+   --> core/rag/extractor/notion_extractor.py:107:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:174:29
+   --> core/rag/extractor/notion_extractor.py:176:29
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:236:25
+   --> core/rag/extractor/notion_extractor.py:238:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:296:25
+   --> core/rag/extractor/notion_extractor.py:298:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:368:21
+   --> core/rag/extractor/notion_extractor.py:372:21
 ERROR Cannot index into `Generator[Unknown]` [bad-index]
    --> core/rag/extractor/watercrawl/client.py:210:54
 ERROR Cannot index into `bytes` [bad-index]
@@ -341,9 +341,9 @@
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/paragraph_index_processor.py:199:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:234:33
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:239:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:235:16
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:240:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/qa_index_processor.py:204:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
@@ -4622,43 +4622,43 @@
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
    --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:203:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:24
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:231:24
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:239:26
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:26
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:249:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:245:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:260:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:256:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:272:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:280:42
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:294:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:290:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:310:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:306:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:324:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:320:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:346:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:342:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:366:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:362:21
 ERROR Object of class `FunctionType` has no attribute `assert_called_once_with` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:372:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:368:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:369:5
 ERROR Object of class `FunctionType` has no attribute `reset_mock` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:375:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:371:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:381:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:21
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:393:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:389:25
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:394:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:390:25
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:400:19
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:396:19
 ERROR Object of class `ModuleType` has no attribute `analyse` [missing-attribute]
   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba_keyword_table_handler.py:30:5
 ERROR Object of class `ModuleType` has no attribute `default_tfidf` [missing-attribute]
@@ -5112,7 +5112,7 @@
 ERROR Argument `list[str]` is not assignable to parameter `docs` with type `Sequence[Document]` in function `core.rag.docstore.dataset_docstore.DatasetDocumentStore.add_documents` [bad-argument-type]
    --> tests/unit_tests/core/rag/docstore/test_dataset_docstore.py:307:37
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:304:85
+   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:293:85
 ERROR Object of class `PartialImpl` has no attribute `embed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:127:13
 ERROR Object of class `PartialImpl` has no attribute `embed_documents` [missing-attribute]
@@ -5126,9 +5126,9 @@
 ERROR Object of class `PartialImpl` has no attribute `aembed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:218:23
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:571:85
+   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:559:85
 ERROR Argument `list[LiteralString]` is not assignable to parameter `texts` with type `list[str]` in function `core.rag.embedding.cached_embedding.CacheEmbedding.embed_documents` [bad-argument-type]
-    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1334:54
+    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1322:54
 ERROR Class member `_ManagedStringIO.__exit__` overrides parent class `StringIO` in an inconsistent manner [bad-param-name-override]
   --> tests/unit_tests/core/rag/extractor/test_csv_extractor.py:16:9
 ERROR Argument `SimpleNamespace` is not assignable to parameter `upload_file` with type `UploadFile` in function `core.rag.extractor.extract_processor.ExtractProcessor.load_from_upload_file` [bad-argument-type]
@@ -5154,7 +5154,7 @@
 ERROR Object of class `NoneType` has no attribute `strip` [missing-attribute]
   --> tests/unit_tests/core/rag/extractor/test_markdown_extractor.py:30:16
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document_model` with type `Document | None` in function `core.rag.extractor.notion_extractor.NotionExtractor.update_last_edited_time` [bad-argument-type]
-   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:434:43
+   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:435:43
 ERROR Type `object` is not iterable [not-iterable]
   --> tests/unit_tests/core/rag/extractor/test_word_extractor.py:90:9
 ERROR `Any | None` is not assignable to attribute `FILES_URL` with type `str` [bad-assignment]
@@ -5174,11 +5174,11 @@
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.paragraph_index_processor.ParagraphIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_paragraph_index_processor.py:241:39
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor.retrieve` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:312:39
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:305:39
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:322:88
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:315:88
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:340:63
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:333:63
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.qa_index_processor.QAIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_qa_index_processor.py:267:39
 ERROR Missing required key `enable` for TypedDict `SummaryIndexSettingDict` [bad-typed-dict-key]
@@ -5192,13 +5192,13 @@
 ERROR Argument `Literal['completed']` is not assignable to parameter `after_indexing_status` with type `IndexingStatus` in function `core.indexing_runner.IndexingRunner._update_document_index_status` [bad-argument-type]
     --> tests/unit_tests/core/rag/indexing/test_indexing_runner.py:1071:71
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1587:9
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1578:9
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1588:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1579:16
 ERROR Object of class `FunctionType` has no attribute `call_count` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1639:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1630:16
 ERROR No matching overload found for function `_pytest.raises.raises` called with arguments: (tuple[type[TypeError], type[AttributeError]]) [no-matching-overload]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1846:31
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1837:31
 ERROR Argument `list[float] | None` is not assignable to parameter `obj` with type `Sized` in function `len` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:1951:20
 ERROR Could not find name `metadata_name` [unknown-name]
@@ -5210,29 +5210,29 @@
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval._handle_invoke_result` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:3788:67
 ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4028:16
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4027:16
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4562:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4561:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4614:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4613:40
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4619:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4618:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4635:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4634:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4665:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4664:36
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4670:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4669:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4678:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4677:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4714:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4713:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4742:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4741:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4800:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4799:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4844:44
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4843:44
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.router.multi_dataset_react_route.ReactMultiDatasetRouter._handle_invoke_result` [bad-argument-type]
    --> tests/unit_tests/core/rag/retrieval/test_multi_dataset_react_route.py:198:52
 ERROR Argument `None` is not assignable to parameter `text` with type `str` in function `core.rag.splitter.text_splitter.RecursiveCharacterTextSplitter.split_text` [bad-argument-type]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Pyrefly Diff

base → PR 
--- /tmp/pyrefly_base.txt	2026-03-27 16:42:50.889310101 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-27 16:42:39.035139340 +0000
@@ -262,13 +262,13 @@
 ERROR Unpacked keyword argument `bool | float | int | str | None` is not assignable to parameter `auth_token_provider` with type `(() -> Awaitable[str]) | (() -> str) | None` in function `qdrant_client.qdrant_client.QdrantClient.__init__` [bad-argument-type]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:87:51
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:40
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:449:40
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:42
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:42
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:37
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:37
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:453:38
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:38
 ERROR `None` is not subscriptable [unsupported-operation]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_service.py:62:20
 ERROR `None` is not subscriptable [unsupported-operation]
@@ -286,15 +286,15 @@
 ERROR `response` may be uninitialized [unbound-name]
    --> core/rag/extractor/firecrawl/firecrawl_app.py:193:16
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.post` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:105:25
+   --> core/rag/extractor/notion_extractor.py:106:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:174:29
+   --> core/rag/extractor/notion_extractor.py:175:29
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:236:25
+   --> core/rag/extractor/notion_extractor.py:237:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:296:25
+   --> core/rag/extractor/notion_extractor.py:297:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:368:21
+   --> core/rag/extractor/notion_extractor.py:371:21
 ERROR Cannot index into `Generator[Unknown]` [bad-index]
    --> core/rag/extractor/watercrawl/client.py:210:54
 ERROR Cannot index into `bytes` [bad-index]
@@ -341,9 +341,9 @@
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/paragraph_index_processor.py:199:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:234:33
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:239:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:235:16
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:240:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/qa_index_processor.py:204:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
@@ -4622,43 +4622,43 @@
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
    --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:203:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:24
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:231:24
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:239:26
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:26
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:249:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:245:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:260:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:256:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:272:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:280:42
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:294:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:290:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:310:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:306:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:324:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:320:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:346:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:342:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:366:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:362:21
 ERROR Object of class `FunctionType` has no attribute `assert_called_once_with` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:372:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:368:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:369:5
 ERROR Object of class `FunctionType` has no attribute `reset_mock` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:375:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:371:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:381:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:21
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:393:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:389:25
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:394:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:390:25
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:400:19
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:396:19
 ERROR Object of class `ModuleType` has no attribute `analyse` [missing-attribute]
   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba_keyword_table_handler.py:30:5
 ERROR Object of class `ModuleType` has no attribute `default_tfidf` [missing-attribute]
@@ -5112,7 +5112,7 @@
 ERROR Argument `list[str]` is not assignable to parameter `docs` with type `Sequence[Document]` in function `core.rag.docstore.dataset_docstore.DatasetDocumentStore.add_documents` [bad-argument-type]
    --> tests/unit_tests/core/rag/docstore/test_dataset_docstore.py:307:37
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:304:85
+   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:293:85
 ERROR Object of class `PartialImpl` has no attribute `embed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:127:13
 ERROR Object of class `PartialImpl` has no attribute `embed_documents` [missing-attribute]
@@ -5126,9 +5126,9 @@
 ERROR Object of class `PartialImpl` has no attribute `aembed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:218:23
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:571:85
+   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:559:85
 ERROR Argument `list[LiteralString]` is not assignable to parameter `texts` with type `list[str]` in function `core.rag.embedding.cached_embedding.CacheEmbedding.embed_documents` [bad-argument-type]
-    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1334:54
+    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1322:54
 ERROR Class member `_ManagedStringIO.__exit__` overrides parent class `StringIO` in an inconsistent manner [bad-param-name-override]
   --> tests/unit_tests/core/rag/extractor/test_csv_extractor.py:16:9
 ERROR Argument `SimpleNamespace` is not assignable to parameter `upload_file` with type `UploadFile` in function `core.rag.extractor.extract_processor.ExtractProcessor.load_from_upload_file` [bad-argument-type]
@@ -5154,7 +5154,7 @@
 ERROR Object of class `NoneType` has no attribute `strip` [missing-attribute]
   --> tests/unit_tests/core/rag/extractor/test_markdown_extractor.py:30:16
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document_model` with type `Document | None` in function `core.rag.extractor.notion_extractor.NotionExtractor.update_last_edited_time` [bad-argument-type]
-   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:434:43
+   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:435:43
 ERROR Type `object` is not iterable [not-iterable]
   --> tests/unit_tests/core/rag/extractor/test_word_extractor.py:90:9
 ERROR `Any | None` is not assignable to attribute `FILES_URL` with type `str` [bad-assignment]
@@ -5174,11 +5174,11 @@
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.paragraph_index_processor.ParagraphIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_paragraph_index_processor.py:241:39
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor.retrieve` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:312:39
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:305:39
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:322:88
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:315:88
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:340:63
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:333:63
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.qa_index_processor.QAIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_qa_index_processor.py:267:39
 ERROR Missing required key `enable` for TypedDict `SummaryIndexSettingDict` [bad-typed-dict-key]
@@ -5192,13 +5192,13 @@
 ERROR Argument `Literal['completed']` is not assignable to parameter `after_indexing_status` with type `IndexingStatus` in function `core.indexing_runner.IndexingRunner._update_document_index_status` [bad-argument-type]
     --> tests/unit_tests/core/rag/indexing/test_indexing_runner.py:1071:71
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1587:9
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1578:9
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1588:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1579:16
 ERROR Object of class `FunctionType` has no attribute `call_count` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1639:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1630:16
 ERROR No matching overload found for function `_pytest.raises.raises` called with arguments: (tuple[type[TypeError], type[AttributeError]]) [no-matching-overload]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1846:31
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1837:31
 ERROR Argument `list[float] | None` is not assignable to parameter `obj` with type `Sized` in function `len` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:1951:20
 ERROR Could not find name `metadata_name` [unknown-name]
@@ -5210,29 +5210,29 @@
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval._handle_invoke_result` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:3788:67
 ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4028:16
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4027:16
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4562:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4561:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4614:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4613:40
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4619:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4618:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4635:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4634:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4665:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4664:36
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4670:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4669:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4678:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4677:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4714:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4713:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4742:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4741:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4800:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4799:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4844:44
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4843:44
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.router.multi_dataset_react_route.ReactMultiDatasetRouter._handle_invoke_result` [bad-argument-type]
    --> tests/unit_tests/core/rag/retrieval/test_multi_dataset_react_route.py:198:52
 ERROR Argument `None` is not assignable to parameter `text` with type `str` in function `core.rag.splitter.text_splitter.RecursiveCharacterTextSplitter.split_text` [bad-argument-type]

@RenzoMXD
Copy link
Copy Markdown
Contributor Author

RenzoMXD commented Mar 27, 2026

@asukaminato0721 Can you review my PR again please? Thanks.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Pyrefly Diff

base → PR 
--- /tmp/pyrefly_base.txt	2026-03-27 22:33:08.197928997 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-27 22:32:57.338947335 +0000
@@ -262,13 +262,13 @@
 ERROR Unpacked keyword argument `bool | float | int | str | None` is not assignable to parameter `auth_token_provider` with type `(() -> Awaitable[str]) | (() -> str) | None` in function `qdrant_client.qdrant_client.QdrantClient.__init__` [bad-argument-type]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:87:51
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:40
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:449:40
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:42
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:42
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:37
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:37
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:453:38
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:38
 ERROR `None` is not subscriptable [unsupported-operation]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_service.py:62:20
 ERROR `None` is not subscriptable [unsupported-operation]
@@ -286,15 +286,15 @@
 ERROR `response` may be uninitialized [unbound-name]
    --> core/rag/extractor/firecrawl/firecrawl_app.py:193:16
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.post` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:105:25
+   --> core/rag/extractor/notion_extractor.py:106:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:174:29
+   --> core/rag/extractor/notion_extractor.py:175:29
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:236:25
+   --> core/rag/extractor/notion_extractor.py:237:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:296:25
+   --> core/rag/extractor/notion_extractor.py:297:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:368:21
+   --> core/rag/extractor/notion_extractor.py:371:21
 ERROR Cannot index into `Generator[Unknown]` [bad-index]
    --> core/rag/extractor/watercrawl/client.py:210:54
 ERROR Cannot index into `bytes` [bad-index]
@@ -337,13 +337,13 @@
 ERROR Object of class `BaseOxmlElement` has no attribute `body` [missing-attribute]
    --> core/rag/extractor/word_extractor.py:426:24
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/paragraph_index_processor.py:199:33
+   --> core/rag/index_processor/processor/paragraph_index_processor.py:198:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/paragraph_index_processor.py:200:16
+   --> core/rag/index_processor/processor/paragraph_index_processor.py:199:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:234:33
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:239:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:235:16
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:240:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/qa_index_processor.py:204:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
@@ -4616,43 +4616,43 @@
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
    --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:203:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:24
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:231:24
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:239:26
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:26
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:249:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:245:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:260:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:256:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:272:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:280:42
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:294:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:290:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:310:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:306:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:324:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:320:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:346:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:342:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:366:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:362:21
 ERROR Object of class `FunctionType` has no attribute `assert_called_once_with` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:372:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:368:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:369:5
 ERROR Object of class `FunctionType` has no attribute `reset_mock` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:375:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:371:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:381:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:21
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:393:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:389:25
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:394:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:390:25
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:400:19
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:396:19
 ERROR Object of class `ModuleType` has no attribute `analyse` [missing-attribute]
   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba_keyword_table_handler.py:30:5
 ERROR Object of class `ModuleType` has no attribute `default_tfidf` [missing-attribute]
@@ -5106,7 +5106,7 @@
 ERROR Argument `list[str]` is not assignable to parameter `docs` with type `Sequence[Document]` in function `core.rag.docstore.dataset_docstore.DatasetDocumentStore.add_documents` [bad-argument-type]
    --> tests/unit_tests/core/rag/docstore/test_dataset_docstore.py:307:37
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:304:85
+   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:293:85
 ERROR Object of class `PartialImpl` has no attribute `embed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:127:13
 ERROR Object of class `PartialImpl` has no attribute `embed_documents` [missing-attribute]
@@ -5120,9 +5120,9 @@
 ERROR Object of class `PartialImpl` has no attribute `aembed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:218:23
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:571:85
+   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:559:85
 ERROR Argument `list[LiteralString]` is not assignable to parameter `texts` with type `list[str]` in function `core.rag.embedding.cached_embedding.CacheEmbedding.embed_documents` [bad-argument-type]
-    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1334:54
+    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1322:54
 ERROR Class member `_ManagedStringIO.__exit__` overrides parent class `StringIO` in an inconsistent manner [bad-param-name-override]
   --> tests/unit_tests/core/rag/extractor/test_csv_extractor.py:16:9
 ERROR Argument `SimpleNamespace` is not assignable to parameter `upload_file` with type `UploadFile` in function `core.rag.extractor.extract_processor.ExtractProcessor.load_from_upload_file` [bad-argument-type]
@@ -5148,7 +5148,7 @@
 ERROR Object of class `NoneType` has no attribute `strip` [missing-attribute]
   --> tests/unit_tests/core/rag/extractor/test_markdown_extractor.py:30:16
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document_model` with type `Document | None` in function `core.rag.extractor.notion_extractor.NotionExtractor.update_last_edited_time` [bad-argument-type]
-   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:434:43
+   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:435:43
 ERROR Type `object` is not iterable [not-iterable]
   --> tests/unit_tests/core/rag/extractor/test_word_extractor.py:90:9
 ERROR `Any | None` is not assignable to attribute `FILES_URL` with type `str` [bad-assignment]
@@ -5168,11 +5168,11 @@
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.paragraph_index_processor.ParagraphIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_paragraph_index_processor.py:241:39
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor.retrieve` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:312:39
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:305:39
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:322:88
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:315:88
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:340:63
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:333:63
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.qa_index_processor.QAIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_qa_index_processor.py:267:39
 ERROR Missing required key `enable` for TypedDict `SummaryIndexSettingDict` [bad-typed-dict-key]
@@ -5186,13 +5186,13 @@
 ERROR Argument `Literal['completed']` is not assignable to parameter `after_indexing_status` with type `IndexingStatus` in function `core.indexing_runner.IndexingRunner._update_document_index_status` [bad-argument-type]
     --> tests/unit_tests/core/rag/indexing/test_indexing_runner.py:1071:71
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1587:9
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1578:9
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1588:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1579:16
 ERROR Object of class `FunctionType` has no attribute `call_count` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1639:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1630:16
 ERROR No matching overload found for function `_pytest.raises.raises` called with arguments: (tuple[type[TypeError], type[AttributeError]]) [no-matching-overload]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1846:31
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1837:31
 ERROR Argument `list[float] | None` is not assignable to parameter `obj` with type `Sized` in function `len` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:1951:20
 ERROR Could not find name `metadata_name` [unknown-name]
@@ -5204,29 +5204,29 @@
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval._handle_invoke_result` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:3788:67
 ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4028:16
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4027:16
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4562:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4561:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4614:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4613:40
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4619:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4618:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4635:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4634:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4665:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4664:36
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4670:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4669:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4678:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4677:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4714:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4713:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4742:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4741:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4800:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4799:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4844:44
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4843:44
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.router.multi_dataset_react_route.ReactMultiDatasetRouter._handle_invoke_result` [bad-argument-type]
    --> tests/unit_tests/core/rag/retrieval/test_multi_dataset_react_route.py:199:52
 ERROR Argument `None` is not assignable to parameter `text` with type `str` in function `core.rag.splitter.text_splitter.RecursiveCharacterTextSplitter.split_text` [bad-argument-type]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Pyrefly Diff

base → PR 
--- /tmp/pyrefly_base.txt	2026-03-27 22:35:03.556504176 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-27 22:34:52.511458399 +0000
@@ -262,13 +262,13 @@
 ERROR Unpacked keyword argument `bool | float | int | str | None` is not assignable to parameter `auth_token_provider` with type `(() -> Awaitable[str]) | (() -> str) | None` in function `qdrant_client.qdrant_client.QdrantClient.__init__` [bad-argument-type]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:87:51
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:40
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:449:40
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:42
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:450:42
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:37
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:451:37
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:453:38
+   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_on_qdrant_vector.py:452:38
 ERROR `None` is not subscriptable [unsupported-operation]
   --> core/rag/datasource/vdb/tidb_on_qdrant/tidb_service.py:62:20
 ERROR `None` is not subscriptable [unsupported-operation]
@@ -286,15 +286,15 @@
 ERROR `response` may be uninitialized [unbound-name]
    --> core/rag/extractor/firecrawl/firecrawl_app.py:193:16
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.post` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:105:25
+   --> core/rag/extractor/notion_extractor.py:106:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:174:29
+   --> core/rag/extractor/notion_extractor.py:175:29
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:236:25
+   --> core/rag/extractor/notion_extractor.py:237:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:296:25
+   --> core/rag/extractor/notion_extractor.py:297:25
 ERROR Argument `dict[str, bytes | str]` is not assignable to parameter `headers` with type `Headers | Mapping[bytes, bytes] | Mapping[str, str] | Sequence[tuple[bytes, bytes]] | Sequence[tuple[str, str]] | None` in function `httpx._api.request` [bad-argument-type]
-   --> core/rag/extractor/notion_extractor.py:368:21
+   --> core/rag/extractor/notion_extractor.py:371:21
 ERROR Cannot index into `Generator[Unknown]` [bad-index]
    --> core/rag/extractor/watercrawl/client.py:210:54
 ERROR Cannot index into `bytes` [bad-index]
@@ -337,13 +337,13 @@
 ERROR Object of class `BaseOxmlElement` has no attribute `body` [missing-attribute]
    --> core/rag/extractor/word_extractor.py:426:24
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/paragraph_index_processor.py:199:33
+   --> core/rag/index_processor/processor/paragraph_index_processor.py:198:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/paragraph_index_processor.py:200:16
+   --> core/rag/index_processor/processor/paragraph_index_processor.py:199:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:234:33
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:239:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
-   --> core/rag/index_processor/processor/parent_child_index_processor.py:235:16
+   --> core/rag/index_processor/processor/parent_child_index_processor.py:240:16
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/qa_index_processor.py:204:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
@@ -4616,43 +4616,43 @@
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
    --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:203:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:24
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:231:24
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:239:26
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:235:26
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:249:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:245:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:260:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:256:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:272:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:280:42
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:276:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:294:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:290:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:310:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:306:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:324:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:320:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:346:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:342:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:366:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:362:21
 ERROR Object of class `FunctionType` has no attribute `assert_called_once_with` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:372:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:368:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:369:5
 ERROR Object of class `FunctionType` has no attribute `reset_mock` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:375:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:371:5
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:5
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:373:5
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `core.rag.datasource.keyword.jieba.jieba.Jieba.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:381:21
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:377:21
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:393:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:389:25
 ERROR `SimpleNamespace` is not assignable to TypedDict key `segment` with type `DocumentSegment` [bad-typed-dict-key]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:394:25
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:390:25
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:400:19
+   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba.py:396:19
 ERROR Object of class `ModuleType` has no attribute `analyse` [missing-attribute]
   --> tests/unit_tests/core/rag/datasource/keyword/jieba/test_jieba_keyword_table_handler.py:30:5
 ERROR Object of class `ModuleType` has no attribute `default_tfidf` [missing-attribute]
@@ -5106,7 +5106,7 @@
 ERROR Argument `list[str]` is not assignable to parameter `docs` with type `Sequence[Document]` in function `core.rag.docstore.dataset_docstore.DatasetDocumentStore.add_documents` [bad-argument-type]
    --> tests/unit_tests/core/rag/docstore/test_dataset_docstore.py:307:37
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:304:85
+   --> tests/unit_tests/core/rag/embedding/test_cached_embedding.py:293:85
 ERROR Object of class `PartialImpl` has no attribute `embed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:127:13
 ERROR Object of class `PartialImpl` has no attribute `embed_documents` [missing-attribute]
@@ -5120,9 +5120,9 @@
 ERROR Object of class `PartialImpl` has no attribute `aembed_query` [missing-attribute]
    --> tests/unit_tests/core/rag/embedding/test_embedding_base.py:218:23
 ERROR Argument `None` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:571:85
+   --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:559:85
 ERROR Argument `list[LiteralString]` is not assignable to parameter `texts` with type `list[str]` in function `core.rag.embedding.cached_embedding.CacheEmbedding.embed_documents` [bad-argument-type]
-    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1334:54
+    --> tests/unit_tests/core/rag/embedding/test_embedding_service.py:1322:54
 ERROR Class member `_ManagedStringIO.__exit__` overrides parent class `StringIO` in an inconsistent manner [bad-param-name-override]
   --> tests/unit_tests/core/rag/extractor/test_csv_extractor.py:16:9
 ERROR Argument `SimpleNamespace` is not assignable to parameter `upload_file` with type `UploadFile` in function `core.rag.extractor.extract_processor.ExtractProcessor.load_from_upload_file` [bad-argument-type]
@@ -5148,7 +5148,7 @@
 ERROR Object of class `NoneType` has no attribute `strip` [missing-attribute]
   --> tests/unit_tests/core/rag/extractor/test_markdown_extractor.py:30:16
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document_model` with type `Document | None` in function `core.rag.extractor.notion_extractor.NotionExtractor.update_last_edited_time` [bad-argument-type]
-   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:434:43
+   --> tests/unit_tests/core/rag/extractor/test_notion_extractor.py:435:43
 ERROR Type `object` is not iterable [not-iterable]
   --> tests/unit_tests/core/rag/extractor/test_word_extractor.py:90:9
 ERROR `Any | None` is not assignable to attribute `FILES_URL` with type `str` [bad-assignment]
@@ -5168,11 +5168,11 @@
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.paragraph_index_processor.ParagraphIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_paragraph_index_processor.py:241:39
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor.retrieve` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:312:39
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:305:39
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:322:88
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:315:88
 ERROR Argument `SimpleNamespace` is not assignable to parameter `rules` with type `Rule` in function `core.rag.index_processor.processor.parent_child_index_processor.ParentChildIndexProcessor._split_child_nodes` [bad-argument-type]
-   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:340:63
+   --> tests/unit_tests/core/rag/indexing/processor/test_parent_child_index_processor.py:333:63
 ERROR Argument `Literal['semantic_search']` is not assignable to parameter `retrieval_method` with type `RetrievalMethod` in function `core.rag.index_processor.processor.qa_index_processor.QAIndexProcessor.retrieve` [bad-argument-type]
    --> tests/unit_tests/core/rag/indexing/processor/test_qa_index_processor.py:267:39
 ERROR Missing required key `enable` for TypedDict `SummaryIndexSettingDict` [bad-typed-dict-key]
@@ -5186,13 +5186,13 @@
 ERROR Argument `Literal['completed']` is not assignable to parameter `after_indexing_status` with type `IndexingStatus` in function `core.indexing_runner.IndexingRunner._update_document_index_status` [bad-argument-type]
     --> tests/unit_tests/core/rag/indexing/test_indexing_runner.py:1071:71
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1587:9
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1578:9
 ERROR Object of class `FunctionType` has no attribute `call_args` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1588:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1579:16
 ERROR Object of class `FunctionType` has no attribute `call_count` [missing-attribute]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1639:16
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1630:16
 ERROR No matching overload found for function `_pytest.raises.raises` called with arguments: (tuple[type[TypeError], type[AttributeError]]) [no-matching-overload]
-    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1846:31
+    --> tests/unit_tests/core/rag/rerank/test_reranker.py:1837:31
 ERROR Argument `list[float] | None` is not assignable to parameter `obj` with type `Sized` in function `len` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:1951:20
 ERROR Could not find name `metadata_name` [unknown-name]
@@ -5204,29 +5204,29 @@
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval._handle_invoke_result` [bad-argument-type]
     --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:3788:67
 ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4028:16
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4027:16
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4562:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4561:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4614:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4613:40
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4619:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4618:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4635:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4634:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4665:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4664:36
 ERROR Argument `SimpleNamespace` is not assignable to parameter `metadata_condition` with type `MetadataCondition | None` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4670:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4669:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.single_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4678:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4677:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4714:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4713:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4742:36
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4741:36
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4800:40
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4799:40
 ERROR Argument `list[SimpleNamespace]` is not assignable to parameter `available_datasets` with type `list[Dataset]` in function `core.rag.retrieval.dataset_retrieval.DatasetRetrieval.multiple_retrieve` [bad-argument-type]
-    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4844:44
+    --> tests/unit_tests/core/rag/retrieval/test_dataset_retrieval.py:4843:44
 ERROR Argument `Iterator[Any]` is not assignable to parameter `invoke_result` with type `Generator[Unknown]` in function `core.rag.retrieval.router.multi_dataset_react_route.ReactMultiDatasetRouter._handle_invoke_result` [bad-argument-type]
    --> tests/unit_tests/core/rag/retrieval/test_multi_dataset_react_route.py:199:52
 ERROR Argument `None` is not assignable to parameter `text` with type `str` in function `core.rag.splitter.text_splitter.RecursiveCharacterTextSplitter.split_text` [bad-argument-type]

@RenzoMXD RenzoMXD mentioned this pull request Mar 28, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@asukaminato0721 asukaminato0721 asukaminato0721 left review comments

@JohnJyong JohnJyong Awaiting requested review from JohnJyong JohnJyong is a code owner

@laipz8200 laipz8200 Awaiting requested review from laipz8200 laipz8200 is a code owner

@QuantumGhost QuantumGhost Awaiting requested review from QuantumGhost QuantumGhost is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer refactor size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RenzoMXD @asukaminato0721