Skip to content

fix: bridge Dify design tokens for streamdown table fullscreen#34224

Open
ZZITE wants to merge 1 commit intolanggenius:mainfrom
ZZITE:fix/table-fullscreen-missing-background
Open

fix: bridge Dify design tokens for streamdown table fullscreen#34224
ZZITE wants to merge 1 commit intolanggenius:mainfrom
ZZITE:fix/table-fullscreen-missing-background

Conversation

@ZZITE
Copy link
Copy Markdown

@ZZITE ZZITE commented Mar 28, 2026

Made-with: Cursor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

  • Streamdown's table fullscreen uses createPortal to document.body, with shadcn/ui Tailwind classes (bg-background, bg-muted, border-border, etc.) that don't resolve in Dify's design system — resulting in missing background, borders, and text colors.
  • Added CSS overrides for [data-streamdown="table-fullscreen"] in markdown.css, following the same pattern already used for [data-streamdown="table-wrapper"].
    fixes View fullscreen error #34182

Screenshots

Before After
image image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@ZZITE ZZITE requested a review from iamjoel as a code owner March 28, 2026 09:48
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 28, 2026
@github-actions github-actions bot added the web This relates to changes on the web. label Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View fullscreen error

1 participant