fix(weaviate): delete vectors by document ID#39176
Open
yuya2017 wants to merge 1 commit into
Open
Conversation
yuya2017
marked this pull request as ready for review
July 17, 2026 06:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Fixes #39175
GitHub did not allow the external issue author to self-assign #39175, so maintainer assignment is still needed.
This PR fixes an identity mismatch in the Weaviate adapter:
BaseVector._get_uuids()and use the segmentdoc_idinstead of a UUID derived only frompage_content.delete_by_ids()deletes by the storeddoc_idproperty instead of treating logical segment IDs as Weaviate object UUIDs.This also addresses the storage collision described in #36137. Unlike the existing proposal in #36140, it aligns Weaviate with the shared
BaseVectoridentity contract and fixes deletion of both new and legacy objects.Screenshots
Not applicable; this is a backend vector-store fix.
Validation
make test TARGET_TESTS=./api/providers/vdb/vdb-weaviate/tests/unit_tests/test_weaviate_vector.py— 40 passed.ruff format --checkandruff checkfor the three changed files — passed.50051; the run timed out during batch insertion. The temporary test collection was removed. The regression assertion is included for CI's Docker-backed Weaviate test environment.weaviate_vector.py; no error points to this diff.Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods