[13.x] Support Delay attribute when using Bus::batch & bulk#60766
Draft
jackbayliss wants to merge 5 commits into
Draft
[13.x] Support Delay attribute when using Bus::batch & bulk#60766jackbayliss wants to merge 5 commits into
Delay attribute when using Bus::batch & bulk#60766jackbayliss wants to merge 5 commits into
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Delay attribute when using Bus::batch & bulkDelay attribute when using Bus::batch & bulk
jackbayliss
force-pushed
the
13.x-support-delay-attr-for-bus-batch-and-bulk
branch
from
July 14, 2026 00:06
2c7c4d9 to
f21f71d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this earlier via this, jobs pushed via
Bus::batch()andBus::bulkalready respect$delayas a property, but, they ignore the Delay attribute.This PR ensures the attribute is also covered. As I would expect the same behavior.
The SQS driver was already doing a
is_objectcheck, so I've replicated elsewhere.This mean each Queue class checks the attribute / param now basically.
This means it fixes the below:
Code example
This isn't officially documented, but feels odd to support only the param and not the attr?
This also ensures there's no fifo etc issues, as the drivers are already responsible for this 🫡
Open to your feedback, maybe this sux? thanks!