Skip to content

fix(mail): hide lint counts + tip from default writepath envelope #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xulong3370 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(mail): hide lint counts + tip from default writepath envelope #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
094b999
feat(mail): HTML lint lib + Larksuite-native autofix + lark-mail skill
bubbmon233 May 8, 2026
d0b0489
fix(mail): gate lint_applied_count/original_blocked_count behind --sh…
xulong3370 May 11, 2026
0c5ebbb
fix(mail): remove tip field from default draft-saved envelope
xulong3370 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion shortcuts/mail/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2192,10 +2192,21 @@ func buildDraftSendOutput(resData map[string]interface{}, mailboxID string) map[

// buildDraftSavedOutput formats a successful drafts.create / drafts.update
// response into the public output map (draft_id + optional preview URL).
//
// The default envelope is intentionally minimal per tech-design §4.1.5
// (token-frugal contract: only {compose_hint, draft_id, reference} for the
// save-as-draft path on +send / +reply / +reply-all / +forward). The same
// "how to send the draft" hint is emitted on stderr by hintSendDraft so UX
// is unchanged; it is not duplicated into the JSON envelope.
//
// The mailboxID parameter is retained for backward compatibility with the
// four callers (mail_send.go / mail_reply.go / mail_reply_all.go /
// mail_forward.go) and may be used in the future; it is intentionally
// unused inside the body now that the tip has moved to stderr.
func buildDraftSavedOutput(draftResult draftpkg.DraftResult, mailboxID string) map[string]interface{} {
_ = mailboxID // reserved; tip teaching is emitted via hintSendDraft on stderr
out := map[string]interface{}{
"draft_id": draftResult.DraftID,
"tip": fmt.Sprintf(`draft saved. To send: lark-cli mail user_mailbox.drafts send --params '{"user_mailbox_id":"%s","draft_id":"%s"}'`, mailboxID, draftResult.DraftID),
}
if draftResult.Reference != "" {
out["reference"] = draftResult.Reference
Expand Down
Loading
Loading