Skip to content

add addsign and rollback method#867

Open
Paulazaaza-dev wants to merge 1 commit into
larksuite:mainfrom
Paulazaaza-dev:feat/approval-support-addsign
Open

add addsign and rollback method#867
Paulazaaza-dev wants to merge 1 commit into
larksuite:mainfrom
Paulazaaza-dev:feat/approval-support-addsign

Conversation

@Paulazaaza-dev
Copy link
Copy Markdown
Contributor

@Paulazaaza-dev Paulazaaza-dev commented May 13, 2026

Summary

Add the functions of "return approval task" and "add approvers"

Changes

  • Return approval task: Rolls back the current approval to one or more approved task nodes. After the rollback, the approved nodes will generate approval tasks again.
  • Add approvers: Adds an approver to a single approval task.

Summary by CodeRabbit

  • Documentation
    • Documented two new approval task operations: add signing and rollback functionality. Updated permissions reference with required authorization scopes for both operations.

Review Change Stack

Change-Id: I0a50796cf33fd59e4222f26003efd43aa7c5896a
@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label May 13, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c12f6d91-6d2e-438c-82f2-0c250352b560

📥 Commits

Reviewing files that changed from the base of the PR and between b0c9a4d and b1c3b9d.

📒 Files selected for processing (1)
  • skills/lark-approval/SKILL.md

📝 Walkthrough

Walkthrough

This PR documents two new task operations (add_sign and rollback) in the Lark approval skill manifest, adding them to the resource documentation list and extending the permissions table to specify the required approval:task:write scope for both operations.

Changes

Lark Approval Skill Documentation

Layer / File(s) Summary
Task Operations and Permissions Documentation
skills/lark-approval/SKILL.md
Resource operations list extended with add_sign and rollback task operations; permissions table populated with corresponding approval:task:write scopes for both operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • larksuite/cli#554: Similar documentation updates to the same Lark approval skill file, extending the tasks resource with new operation entries.

Suggested reviewers

  • liangshuo-1
  • tengchengwei

Poem

🐰 Two new tasks hop into view,
With permissions bright and true,
add_sign and rollback find their place,
In the skill file's documented space! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is missing the 'Test Plan' and 'Related Issues' sections required by the repository template, though it provides adequate Summary and Changes sections. Add 'Test Plan' section with verification details and 'Related Issues' section to fully comply with the repository's description template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'add addsign and rollback method' accurately summarizes the main changes, which add two new API task operations (add_sign and rollback) to the approval skill documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant