Skip to content

chore: Migrate dotnet-sdk-internal into dotnet-core#298

Open
jsonbailey wants to merge 1 commit into
mainfrom
jb/sdk-2572/migrate-internal-to-dotnet-core
Open

chore: Migrate dotnet-sdk-internal into dotnet-core#298
jsonbailey wants to merge 1 commit into
mainfrom
jb/sdk-2572/migrate-internal-to-dotnet-core

Conversation

@jsonbailey

@jsonbailey jsonbailey commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Overview

Migrates the LaunchDarkly.InternalSdk package from the standalone dotnet-sdk-internal repo into this monorepo at pkgs/shared/internal/, following the pattern used for dotnet-sdk-common (#105) and its follow-up corrections (#117, #121, #123, #124).

Resolves SDK-2572.

Intentionally a chore: so release-please does not cut a release for the migration itself. The manifest is seeded at the current version (3.8.0); the first real release happens on the next feat/fix touching the package.

What's included

Not included (deliberately)

  • No consumer changes. The server/client SDKs keep their published LaunchDarkly.InternalSdk PackageReference; bumping them to a monorepo-published version is a separate follow-up PR.
  • The old repo is untouched (archival is tracked separately under SDK-2573).

Validation

  • net8.0: 180/180 unit tests pass in the new location.
  • netstandard2.0: builds clean. (net462 is Windows-only — covered by the CI matrix.)
  • release-please-config.json / manifest are valid JSON; package-name matches the real <PackageId> and the extra-files csproj path resolves correctly.

Note

Low Risk
Repo layout and CI/release wiring only; implementation is a verbatim import with unchanged signing and no consumer dependency changes in this PR.

Overview
This PR brings LaunchDarkly.InternalSdk into the monorepo at pkgs/shared/internal/, mirroring how shared common packages live here. Library source, tests, changelog, and package metadata are added under that path (seeded at 3.8.0 in .release-please-manifest.json).

Build and release plumbing is extended so the package is first-class in this repo: DotnetCore.sln nests the new projects, server-shared-internal.yml runs build/test on path changes (Ubuntu netstandard2.0 / Windows net462), and release-please.yml / release.yml gain a pkgs/shared/internal release path with provenance, aligned with other shared packages.

Signing is wired through github_actions.env to the same strong-name key as before; the csproj only changes the AssemblyOriginatorKeyFile path for the new layout. No server/client SDK PackageReference bumps are in this diff—those stay on the published NuGet until a follow-up.

Reviewed by Cursor Bugbot for commit ef4e59b. Bugbot is set up for automated code reviews on this repo. Configure here.

@jsonbailey jsonbailey force-pushed the jb/sdk-2572/migrate-internal-to-dotnet-core branch from f2a2676 to 8475a80 Compare June 25, 2026 22:28
@jsonbailey jsonbailey marked this pull request as ready for review July 7, 2026 13:42
@jsonbailey jsonbailey requested a review from a team as a code owner July 7, 2026 13:42
Relocate the LaunchDarkly.InternalSdk package from the standalone
dotnet-sdk-internal repo into pkgs/shared/internal, following the pattern used
for dotnet-sdk-common (#105) and its follow-up corrections (#117/#121/#123/#124).

- Copy src/ and test/ verbatim. Preserve the existing strong-name signing key:
  the same S3 source (launchdarkly-releaser/dotnet/LaunchDarkly.snk) is used, so
  the assembly public-key token is unchanged.
- Add monorepo release wiring: github_actions.env, docfx.json, CI workflow
  (server-shared-internal.yml), release-please config + manifest (seeded at the
  current version 3.8.0), and release.yml / release-please.yml entries.
- No consumer changes; the server/client SDKs keep their published
  LaunchDarkly.InternalSdk PackageReference (bumping that is a follow-up).

SDK-2572
@jsonbailey jsonbailey force-pushed the jb/sdk-2572/migrate-internal-to-dotnet-core branch from b4970bb to ef4e59b Compare July 7, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant