chore: bump iOS deployment target to 13.0 for latest SDK compatibility#54
Draft
kinyoklion wants to merge 1 commit into
Draft
chore: bump iOS deployment target to 13.0 for latest SDK compatibility#54kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
The LaunchDarkly iOS SDK 10.0+ requires iOS 13.0 minimum. Update Podfile platform and Xcode project deployment targets. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the iOS deployment target from 12.0 to 13.0 so that CocoaPods can resolve the latest LaunchDarkly iOS SDK (11.x). The SDK's 10.0.0 release dropped support for iOS 12, so with the previous
platform :ios, '12.0',pod installwould only resolve up to the latest 9.x release (9.15.1) instead of the current 11.1.3.Changes:
platform :ios, '12.0'→'13.0'IPHONEOS_DEPLOYMENT_TARGETentries updated to13.0(previously a mix of10.3at the project level and12.0at the target level)The Podfile version specifier (
>= 9.6.0) is intentionally unchanged — the minimum SDK version is preserved.Related PRs in sibling repos: hello-ios (adds watchOS 6.0 bump), hello-tvos (tvOS 13.0 bump).
Review & Testing Checklist for Human
pod installand verify CocoaPods resolvesLaunchDarklyto 11.x (not 9.x)LDClient.get(),observe(key:owner:),boolVariation(forKey:defaultValue:)) still compile and behave correctly with SDK 11.xNotes
pod installwas not run andPodfile.lockwas not regenerated. The reviewer will need to do this locally.10.3(stale from an older Xcode version); it has been normalized to13.0alongside the target-level settings.Link to Devin session: https://app.devin.ai/sessions/79411e068f79496bbbb41d24c39cffd4
Requested by: @kinyoklion