fix: Guard against null scheme in RedisStoreImplBase for relative URIs#185
Merged
tanderson-ld merged 2 commits intoJul 6, 2026
Merged
Conversation
tanderson-ld
approved these changes
Jul 6, 2026
tanderson-ld
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URI.getScheme()returnsnullfor scheme-less URIs such as//localhost:6379.In
RedisStoreImplBase, the TLS detection line:called .equals() on that null, throwing an NPE at store construction time.
Fixed by flipping to the null-safe form:
boolean tls = builder.tls || "rediss".equals(builder.uri.getScheme());
A scheme-less URI now correctly resolves TLS to false (unless explicitly set via .tls(true)).
Note
Low Risk
Single-line defensive null check with unchanged TLS semantics for valid
redis/redissURIs.Overview
Fixes an NPE when constructing the Redis data store from a URI with no scheme (e.g.
//localhost:6379).TLS detection in
RedisStoreImplBaseusedbuilder.uri.getScheme().equals("rediss"), which throws ifgetScheme()isnull. It now uses"rediss".equals(builder.uri.getScheme()), so scheme-less URIs are treated as non-TLS unlessbuilder.tlsis set explicitly.Reviewed by Cursor Bugbot for commit 666069a. Bugbot is set up for automated code reviews on this repo. Configure here.