fix: add accessible names to interactive controls across 21 views#868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
AutomationProperties.Nameto interactive controls across 21 views that lackedaccessible names, so screen readers announce them meaningfully. Generated by a per-view
pass where each view was checked first (a prior accessibility pass — #830/833/835/837/
839/841/843 — already named many controls; those were left untouched and not duplicated).
Scope
~144 names added across: DnsHosts, DiskAnalyzer, DuplicateFile, AppBlocker,
ShortcutCleaner, ContextMenu, BulkInstaller, DeepCleanup, FileShredder, Logs, Ping,
Privacy, ProcessManager, Services, SpeedTest, ThemePopup, Traceroute, Uninstaller,
AppAlerts, AppUpdates, Performance.
Covers: destructive buttons (Delete/Shred/Clear History), icon-only and per-row actions
(named after the row item, e.g.
Remove host entry {0},Add {0} to install list),toggles, ComboBoxes, search/filter TextBoxes, DataGrids, and theme RadioButtons.
Guarantees
AutomationProperties.Nameattribute was added — no layout, style,binding, value, or any other attribute changed. Zero visual change. (Verified by diff:
every removed line is the same element re-emitted with the new attribute appended.)
attribute compiles, so the XAML stays well-formed.
fix:→ patch release (1.20.20). Protocol C to follow.