ci: validate release tag input and skip Codecov on fork PRs#869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CI/CD hardening changes (no application code;
ci:→ no release).Changes
ci.yml— guard the two Codecov steps to skip on fork PRs. Forked pull requestshave no access to repository secrets, so
CODECOV_TOKENis empty there and the uploadwould fail noisily for no benefit. Same-repo pushes/PRs upload normally. (The UI-tests
job already had this fork guard; this brings the coverage steps in line.)
release.yml— validate theworkflow_dispatchtaginput before use:INPUT_TAG/EVENT_NAME/REF_NAME) instead ofinterpolating
${{ inputs.tag }}directly into the pwsh script body — avoids anyscript injection from a crafted manual-dispatch value.
vMAJOR.MINOR.PATCHtag with a clear error before itreaches checkout / version extraction.
Verification
ci:→ no release.