fix: use theme brushes for exact-match hardcoded colors in four views#871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces hardcoded color literals with theme
DynamicResourcebrushes — but onlywhere the hex exactly matches an existing theme color, so every color renders identically
today and now tracks the theme going forward.
Changes (11 exact-match replacements, 4 views)
#22C55E→Success; System-Alertsseverity-dot setters
#22C55E→Success,#F59E0B→Warning,#EF4444→Danger.BorderBrush#2A3244→Border2on the three repair cards.BorderBrush#2A3244→Border2.Fill#6366F1→Accent.Safety
on an exact match against the authoritative App.xaml palette, and to skip and report
anything else. They left 104 non-matching hexes untouched (one-off per-metric accents
like
#3B82F6/#A855F7, and 8-digit ARGB values with alpha) — those would need newtheme tokens, which is a design decision, not a mechanical swap.
Success=#22C55E,Warning=#F59E0B,Danger=#EF4444,Accent=#6366F1,Border2=#2A3244 — byte-identical render.fix:→ patch release (1.20.21). Protocol C to follow.