fix: handle Storage-WMI COM errors, dispose explorer handle, log swallowed exceptions#877
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Error-handling and reliability batch from the audit: missing COM-error handlers, a leaked
process handle, and several silent
catchblocks that now log.Fixes
DiskHealthService/SystemInfoService— the Storage-namespace WMI query caughtManagementException/UnauthorizedAccessExceptionbut not theCOMExceptionthatscope.Connect()throws whenroot\Microsoft\Windows\Storageis absent (older/headlessWindows). DiskHealth now catches it (returns what it has); SystemInfo routes it to the
existing
Win32_DiskDrivefallback. Mirrors the FixedDriveService fix shipped earlier.ProcessManagerService.OpenFileLocation—Process.Start(...)returned aProcesshandle that was discarded undisposed (same leak class as the AdminHelper fix). Now
?.Dispose()d.UpdateService.CleanupFile— emptyIOException/UnauthorizedAccessExceptioncatches.DeepCleanupService— silent inline directory-delete catches.WindowsUpdateService.MapToEntry— empty COM/RuntimeBinder catches on size extraction.DashboardViewModelpolling loop — loggedex.Messageonly → now logs the full exception.Verification
Serilog.Log(fully-qualified) inUpdateServiceandWindowsUpdateService, whereLogis otherwise taken (anevent Action<string>? Login the latter) — verified againsteach file's existing logging style.
fix:→ patch release (1.20.22). Protocol C to follow.