fix: dispose Process.Start handles in explorer/link launch sites#878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disposes the
Processhandle returned byProcess.Start(...)at 10 fire-and-launch sites that previously discarded it — a handle leak (same class as the AdminHelper/ProcessManager fixes shipped earlier).Sites fixed (
...)?.Dispose())ContextMenuService— explorer restart after applying context-menu changesAboutViewModel— updatercmd.exelaunch, 'show in folder', open-URLDeepCleanupViewModel,DiskAnalyzerViewModel,DuplicateFileViewModel,StartupViewModel— 'show in Explorer' row actionsLogsViewModel— open log folder, open Event Viewer, search onlineWhy safe
Process.StartwithUseShellExecute=truereturns a handle to the launched process; disposing the handle does not terminate the process — it only releases the local handle we weren't tracking. Behavior is otherwise identical.Verification
Process.Start(in the app; all results are now disposed, assigned, or returned (none discarded).fix:→ patch release (1.20.23). Protocol C to follow.