fix: preserve all hostnames per IP and write hosts file atomically#882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two P1 reliability fixes in
HostsFileService.Fixes
ReadHostsAsynctook onlytokens[1](the first hostname) from each line, so127.0.0.1 a b clostb/con a read→save round trip. Now emits oneHostsEntryper hostname so all survive.SaveHostscalledFile.WriteAllLinesdirectly over the live hosts file; a crash mid-write could leave it empty/truncated. Now writes tohosts.sysmanager.tmpthenFile.Move(..., overwrite: true)for an atomic replace, with temp cleanup infinally.Tests (the service previously had only backup/restore coverage)
ReadHostsAsync_MultipleHostnamesPerIp_AllPreserved— asserts alpha/beta/gamma all round-trip.SaveHosts_LeavesNoTempFileBehind— asserts the atomic-write temp file is gone after save and content is correct.Both use the existing path-injection
NewServiceWithTempHostshelper (no real System32 hosts touched, no admin).Verification
fix:→ patch release (1.20.24). Protocol C to follow.