feat(evm): add opaque deposit reference to Custody binding#2
Merged
Conversation
Custody.deposit now takes a bytes32 depositReference and the Deposited event carries it (indexed). The reference is opaque and log-only — never validated or stored on-chain — so deposits become filterable per (account, reference) without the contract ascribing sub-account meaning. Regenerated the binding from the refreshed Custody artifact; the SDK depositor passes bytes32(0) (no sub-account). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes the
Custodyartifact + binding sodepositand theDepositedevent carry an opaquebytes32 depositReference.What changed
Custody.deposit(account, asset, amount, **depositReference**)andevent Deposited(account, **depositReference (indexed)**, depositor, asset, amount).(account, reference)without the contract ascribing sub-account meaning.custody_abi.gofrom the refreshedartifacts/Custody.abi+.bin(viago generate).bytes32(0)(no sub-account), soSubmitDeposit's signature is unchanged.Scope
EVM only; withdrawal/rotation surface (
execute/updateSigners/signers/threshold/signerNonce/Executed/SignersUpdated) is unchanged. Tag as v0.1.1 after merge.Verification
go generate,go build ./...,go vet ./...,go test -count=1 ./...— all green.🤖 Generated with Claude Code