Skip to content

Add Solana TypeScript vault depositor#5

Merged
ihsraham merged 2 commits into
masterfrom
feat/solana-ts-depositor
Jun 25, 2026
Merged

Add Solana TypeScript vault depositor#5
ihsraham merged 2 commits into
masterfrom
feat/solana-ts-depositor

Conversation

@ihsraham

@ihsraham ihsraham commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds Solana support to the TypeScript SDK vault depositor flow.

This PR includes native SOL and SPL token deposit support, transaction verification, Solana-specific validation, exports from the SDK entrypoint, integration coverage against the local validator, and a basic browser UI demo.

Changes

  • Added SolanaVaultDepositor under sdk/ts/src/blockchain/sol.
  • Added support for native SOL deposits and SPL token deposits.
  • Added Solana transaction verification returning absent, pending, or confirmed status.
  • Added Solana address, amount, reference, mint, commitment, and transaction reference validation.
  • Reused the shared VaultDepositor destination shape with nested destination.account and optional destination.ref.
  • Added unit tests and Docker-backed Solana integration tests.
  • Added a basic Solana deposit browser demo using Wallet Standard signing and configured-RPC submission.
  • Updated TS package scripts, CI, Makefile, and devnet docs for Solana test/demo coverage.

Demo

ezgif-394a08d6f3c6aa28

Validation

  • npm --prefix sdk/ts run typecheck
  • npm --prefix sdk/ts --workspace @yellow-org/solana-deposit-demo run build
  • npm --prefix sdk/ts audit --omit=dev
  • git diff --check
  • Manual local browser demo: submitted and verified a SOL deposit against the local validator.

@ihsraham ihsraham marked this pull request as ready for review June 23, 2026 12:39

@nksazonov nksazonov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-tested implementation — a few cleanup items and two small bugs worth addressing before merge.

Comment thread sdk/ts/src/blockchain/sol/depositor.ts
Comment thread sdk/ts/src/blockchain/sol/depositor.ts Outdated
Comment thread sdk/ts/src/blockchain/sol/depositor.ts Outdated
Comment thread sdk/ts/src/blockchain/sol/depositor.ts Outdated
Comment thread sdk/ts/src/blockchain/sol/depositor.ts Outdated
Comment thread sdk/ts/test/blockchain/sol/depositor.integration.test.ts Outdated
Comment thread sdk/ts/test/blockchain/sol/depositor.test.ts Outdated
Comment thread sdk/ts/src/blockchain/sol/depositor.ts Outdated
Comment thread sdk/ts/src/blockchain/sol/validation.ts
Comment thread sdk/ts/src/blockchain/sol/types.ts

@nksazonov nksazonov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All review items addressed. Approved.

@ihsraham ihsraham requested a review from philanton June 25, 2026 12:27
@ihsraham ihsraham merged commit 8954de2 into master Jun 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants