fix(release): remove Kaggle-invalid keywords from default keyword set#100
Merged
Conversation
Kaggle rejected "b2b", "crm", "lead-scoring", "saas", "synthetic-data" as unknown tags. Drop them from DEFAULT_KEYWORDS in the Kaggle packager, align REQUIRED_COMMON_TAGS in the lint script to only include tags valid on both platforms (keeping "tabular"), and update the test fixture and golden preview HTML to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shaypal5
added
type: bugfix
|
pr-agent-context report: No unresolved review comments, failing checks, or actionable patch coverage gaps were found on PR #100 in repository https://github.com/leadforge-dev/leadforge. Treat this PR as all clear unless new signals appear.Run metadata: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
b2b,crm,lead-scoring,saas,synthetic-datafromDEFAULT_KEYWORDSinpackage_kaggle_release.py— Kaggle rejected all five as unknown tags duringdataset_metadata_updateREQUIRED_COMMON_TAGSinlint_platform_metadata.pyto only require tags valid on both platforms (onlytabularsurvives); HF-specific tags are still enforced by the separateEXPECTED_HF_TAGSexact-match checktest_lint_platform_metadata.pyand regeneratesrelease/_preview_committed/kaggle.htmlgolden fileContext
The Kaggle live dataset (
derelictpanda/leadforge-lead-scoring-v1) has already had its metadata updated with the correct description, subtitle, MIT license, and cover image. The invalid keywords were silently dropped by the API during that update; this PR makes the source artifacts consistent with what Kaggle actually accepted.Test plan
pytest tests/scripts/test_lint_platform_metadata.py— 12 passedpytest tests/scripts/test_preview_kaggle_page.py— 26 passed🤖 Generated with Claude Code