feat: mid-project lead scoring — generation framework#79
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Adds a new “mid-project” variant of the lead-scoring teaching dataset (student-safe single CSV) plus the build/validate/eval tooling to reproduce and sanity-check it, aligned to the existing v7 schema/narrative.
Changes:
- Introduces
lead_scoring_midproject.csv(1,200 rows) with accompanying BACKGROUND/RELEASE documentation and a saved validation report JSON. - Adds a midproject pipeline module (
leadforge/pipelines/build_midproject.py) and build/validate/baseline-eval scripts underscripts/. - Updates
.agent-plan.mdwith the completed work item entry for this dataset.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/validate_midproject_lead_scoring.py |
New validator for the midproject CSV (schema, missingness, baseline metrics, cohort/value-aware checks). |
scripts/quick_baseline_eval_midproject.py |
Quick baseline runner to reproduce headline metrics and feature importances. |
scripts/build_midproject_lead_scoring.py |
CLI to generate the midproject dataset CSV from the simulator/pipeline. |
leadforge/pipelines/build_midproject.py |
Midproject pipeline configuration (seed=100, subsample=1200) reusing common v6/v7 pipeline steps. |
lead_scoring_midproject/validation_midproject_report.json |
Persisted output from running the validator on the generated CSV. |
lead_scoring_midproject/lead_scoring_midproject.csv |
The generated student-safe dataset artifact. |
lead_scoring_midproject/lead_scoring_midproject_RELEASE.md |
Release documentation with metrics, teaching affordances, and provenance. |
lead_scoring_midproject/lead_scoring_midproject_BACKGROUND.md |
Student-facing narrative/background and feature descriptions. |
.agent-plan.md |
Tracks the completion of the midproject dataset work item. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adds reusable pipeline + scripts for generating and validating the mid-project lead scoring dataset. Dataset artifacts (CSV, docs, validation report) live in leadforge-datasets-private. - leadforge/pipelines/build_midproject.py: pipeline module (seed=100, SUBSAMPLE_N=1200, same schema/missingness as v7) - scripts/build_midproject_lead_scoring.py: build CLI - scripts/validate_midproject_lead_scoring.py: validation script - scripts/quick_baseline_eval_midproject.py: baseline eval script Regenerate the dataset: python scripts/build_midproject_lead_scoring.py OUTPUT_DIR Validate: python scripts/validate_midproject_lead_scoring.py OUTPUT_DIR/lead_scoring_midproject.csv Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
df5361a to
8c78568
Compare
This comment has been minimized.
This comment has been minimized.
- Remove EXPECTED_ROWS and ROW_TOLERANCE (unused dead constants; row-count policy already expressed correctly inline in check_basic) - Guard df[TARGET] in validate() so a missing target column records an error cleanly instead of crashing with KeyError Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
pr-agent-context report: No unresolved review comments, failing checks, or actionable patch coverage gaps were found on PR #79 in repository https://github.com/leadforge-dev/leadforge. Treat this PR as all clear unless new signals appear.Run metadata: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the reusable generation and validation framework for the mid-project lead scoring dataset. No dataset files are committed here (leadforge is a public repo). The generated CSV and release docs live in
leadforge-datasets-private.Files added
leadforge/pipelines/build_midproject.pyscripts/build_midproject_lead_scoring.pypython scripts/build_midproject_lead_scoring.py OUTPUT_DIRscripts/validate_midproject_lead_scoring.pyscripts/quick_baseline_eval_midproject.pyDataset location
Dataset artifacts (CSV, docs, validation report) live in:
leadforge-datasets-private/lead_scoring_midproject/Design
lead_scoring_intro_v7.csv__leakage__columnsRegenerate
Test plan
🤖 Generated with Claude Code